On Fri, Feb 07, 2025 at 02:01:17AM +0100, Stefano Brivio wrote:
> While main() conventionally returns int, and we need a return at the
> end of the function to avoid compiler warnings, turning that return
> into _exit() to avoid exit handlers triggers a Coverity warning. It's
> unreachable code anyway, so switch that single occurence back to a
> plain return.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Gross that we need these workaround hacks, but

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  passt-repair.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/passt-repair.c b/passt-repair.c
> index 5ad5c9c..322066a 100644
> --- a/passt-repair.c
> +++ b/passt-repair.c
> @@ -173,5 +173,5 @@ loop:
>  
>  	goto loop;
>  
> -	_exit(0);
> +	return 0;
>  }

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson