From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=Eu5Z3mBF; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id DCE415A061D for <passt-dev@passt.top>; Thu, 27 Feb 2025 02:57:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1740621440; bh=ENROos1vxgqQlNT7tEeHGSeWmCPxtPwu8+mI4XLl7xo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Eu5Z3mBFSlqSjhS8nv847jCaLxiWm6lXg+nE42n1pj/xSlItVHG9EQSXmfspgHKf/ KnlXDqGcmrxAEOZVYkdLgGk9dRW8wdYmFW30gYU1qGSc9+WHZDQidI3mBY3iibzYS0 miR8D7zAWG7wbHunJnwKC8MY13IGLjM9vdLrSD8tfDZJwI4klcH/rGjaETAWOYoMAT pnE87qi1GHBysX4qdFoSZBW3uAEw/kxx9WCrPfnpj56Z8p5UaihrPhpAu00Ucf3xue rdn2Pimvc27x02xBuiTQ+CckmNtTBAKPzM9G+WYclMP/y49R62SLXV/xKCPRMJ5M/+ 9Ez3Myajeuzpw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Z3DxD36y8z4x5g; Thu, 27 Feb 2025 12:57:20 +1100 (AEDT) Date: Thu, 27 Feb 2025 12:23:32 +1100 From: David Gibson <david@gibson.dropbear.id.au> To: Stefano Brivio <sbrivio@redhat.com> Subject: Re: [PATCH v3 0/3] More graceful handling of migration without passt-repair Message-ID: <Z7--lDjoX52ZnYOt@zatzit> References: <20250226060422.48295-1-david@gibson.dropbear.id.au> <20250226200113.6f90e066@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6OR0Ha5Qbr+XQoWT" Content-Disposition: inline In-Reply-To: <20250226200113.6f90e066@elisabeth> Message-ID-Hash: U6ZFKUI7IQQBIR7XDKX7VVDDNG6B5U4O X-Message-ID-Hash: U6ZFKUI7IQQBIR7XDKX7VVDDNG6B5U4O X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt <passt-dev.passt.top> Archived-At: <https://archives.passt.top/passt-dev/Z7--lDjoX52ZnYOt@zatzit/> Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/U6ZFKUI7IQQBIR7XDKX7VVDDNG6B5U4O/> List-Archive: <https://archives.passt.top/passt-dev/> List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/> List-Help: <mailto:passt-dev-request@passt.top?subject=help> List-Owner: <mailto:passt-dev-owner@passt.top> List-Post: <mailto:passt-dev@passt.top> List-Subscribe: <mailto:passt-dev-join@passt.top> List-Unsubscribe: <mailto:passt-dev-leave@passt.top> --6OR0Ha5Qbr+XQoWT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 26, 2025 at 08:01:13PM +0100, Stefano Brivio wrote: > On Wed, 26 Feb 2025 17:04:19 +1100 > David Gibson <david@gibson.dropbear.id.au> wrote: >=20 > > From Red Hat internal testing we've had some reports that if > > attempting to migrate without passt-repair, the failure mode is uglier > > than we'd like. The migration fails, which is somewhat expected, but > > we don't correctly roll things back on the source, so it breaks > > network there as well. > >=20 > > Handle this more gracefully allowing the migration to proceed in this > > case, but allow TCP connections to break > >=20 > > I've test patches 1..2/3 reasonably: > > * I get a clean migration if there are now active flows > > * Migration completes, although connections are broken if > > passt-repair isn't connected > > * Basic test suite (minus perf) > >=20 > > Patch 3 I've run the basic test suite on, but haven't tested the > > specific functionality of. Alas, I've spent most of today battling > > with RHEL, virt-install, unshare and various other things trying to > > create a test environment simulating two hosts with (possibly) > > different addresses. >=20 > Sorry, I've been busy with other stuff most of the day and I didn't > manage to test the specific functionality of 3/3 either. :( >=20 > I reviewed this and it all looks good to me but I'm not sure if I > should merge this now or wait until we manage to test the 3/3 case. Let > me know your preference. I can also merge up to 2/3 if it makes things > more convenient. Feel free to merge 1..2/3 whenever you want. I'll probably send a new spin with some other things fixed as well today. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --6OR0Ha5Qbr+XQoWT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAme/voQACgkQzQJF27ox 2GfOiw/8CofADHNbf6nhzOGhO3ekvOdrfJUmACrtFmvArIZk/dIPQHqSyXyqLv+R oAXeUK/dvQUtpY4/3/e4kRS9tZnH4Ttq6mZX/wKhE1ftrdS681Vv+SEaSjEV5vI0 fUmv9poljUYGYOsWa9Dvu2G+R2RZWa2MTW+TsxVOgCmy58h6qIRmfbvJeRSgEgxG rITXcva6tiKpY0Ubg8jh2x0G6da2Zq8msiicFZLgm7fnyGPplfpWVTq23JmQfLzS qLRWGMx0R/YVqFkwrju7P7Uc3ms+Q4Relnq4vym01cJx9n70mhbpNLdTxgkOiaND SJHLAAFwSTKyuShygrmmHnTo1HSwpiILw5Ad4dcsKTEc3zGvnjUNnEDppkXJWEaH IcgnKrYZcy/4NYzBhtA0MgjWgmUExOS0AiQpdNlI55D2+9Efpa1Vkx+j3LyvwjOO E8fQ00+vOoA7JRNPrP4r2hq+t4w8JItAX2oMAeoWgHXJRq2qMlsEhVnfK/Sg2+6b MBeRPljmJZzT/m25lSAxrlNQ8C2kYqbF0mn5EaL1kpJfopitPf5WELJJdQ6jtNaM U8awESugfCFq/+4dkNoa4sAwtAi2UiQFLESNDtXhCs494U4oeNjzVVV+NCpua4uc wVnqBbSH1s51wdLuIK/KTSYQsCYYOlEAkYWmjooMe1OZmHLQbxQ= =h6ae -----END PGP SIGNATURE----- --6OR0Ha5Qbr+XQoWT--