From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=MuiKL3th; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id D4EBF5A0274 for ; Mon, 17 Feb 2025 04:47:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1739764033; bh=wCpj8BV0Ku5j2wOXkbF+n2ct5ZeekP24EBtVNWDg8KY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MuiKL3thRHI/5ocHHsLFOpg/uYL6P7db7Bbh7DEX8b1StsL7yPG6zGMPv1Z1JtZmm iWKJsIIlJDmx0RRysZwVcEpl2BVvFfIbCEYpm4rxkaKm2TuWgYkGa5+Bji1jrTqslq sWccf3eO0TCvIyRLg+7gyOD0H3mUdrsFsF2eZv9neYWlysxF3DCki0j+DKjqKB7QSj wzdKZMqS2n2nfFlYmy+eTUUEvgDqlJqaxhGhCT0A+mPWCfXY8p6yVzeztsZIA93SHd 2NKDTjLSLdtt5H8f2/Jq9ofGF7WuAroXofLkouil70qSFyDbH5refVJsjD9Hmu8dvC F1PK2gL+j3b3w== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Yx7rd5NNpz4wyV; Mon, 17 Feb 2025 14:47:13 +1100 (AEDT) Date: Mon, 17 Feb 2025 14:46:43 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v27 1/2] migrate: Migrate TCP flows Message-ID: References: <20250216222227.2017788-1-sbrivio@redhat.com> <20250216222227.2017788-2-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4vLngPrEEc7/KhoN" Content-Disposition: inline In-Reply-To: <20250216222227.2017788-2-sbrivio@redhat.com> Message-ID-Hash: SVIXYEAJL7ARYMHTJXDCWF5LKKKBIXG6 X-Message-ID-Hash: SVIXYEAJL7ARYMHTJXDCWF5LKKKBIXG6 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --4vLngPrEEc7/KhoN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 16, 2025 at 11:22:26PM +0100, Stefano Brivio wrote: > This implements flow preparation on the source, transfer of data with > a format roughly inspired by struct tcp_tap_conn, plus a specific > structure for parameters that don't fit in the flow table, and flow > insertion on the target, with all the appropriate window options, > window scaling, MSS, etc. >=20 > Contents of pending queues are transferred as well. >=20 > The target side is rather convoluted because we first need to create > sockets and switch them to repair mode, before we can apply options > that are *not* stored in the flow table. This also means that, if > we're testing this on the same machine, in the same namespace, we need > to close the listening socket on the source before we can start moving > data. >=20 > Further, we need to connect() the socket on the target before we can > restore data queues, but we can't do that (again, on the same machine) > as long as the matching source socket is open, which implies an > arbitrary limit on queue sizes we can transfer, because we can only > dump pending queues on the source as long as the socket is open, of > course. >=20 > Co-authored-by: David Gibson > Signed-off-by: Stefano Brivio The tests all pass for me, and while I can certainly see things that can be improved, none are urgent. Tested-by: David Gibson Reviewed-by: David Gibson --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --4vLngPrEEc7/KhoN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmeysRcACgkQzQJF27ox 2Gfxaw/8D+M7shx/WS0WBzuhRinMeb68Ld29PeaevMzZ3hortTmJtUc+FcQSgQdQ xZ8ek8Ix80h0C4dyv9ZI7pLet8C9oU7mFyT8ef0OwtSFLkuaD5TdQZS2nCr33xbt dzFYZ8voSZBjN5m6My4bXG8sc+mDT145qvwlDjcI0H7raAw7wvaOZOinEeA+i99L mEYCYuZ8RVnckwFp/HPZjfjvtsxvV7QbOC4ePjgJy1G0x15rQniJ/kNziDeUItPy A7w+TDtSY8PrZy3AGULZy9KT5jERlas6kPCQCtaRWD9M6dyr3588MTfniHCfSKPS UI7tUlA/dY3o+aq6ONYNnqkPtsH27vMAmYpBrYpC8CQGs3DyOW78of124hx0JdhI TBfg+dIxia3Kpv22EDU3quxPHD8FAlUxBFz27u2CdtPPCwznRR6Jr9Fsr9be6EOd JZ7iGKxh6lrqKTPOB9q+GVGzd7dO6uwOaCCa/DzEw8tFF9FVt4LdA8SbQ+2wKY6z oBvhMkaNaxFl6N3fHo/jIfOdJStNLc4JScbIPwgGSLljydBjalzeAJOa1IEMupxz hDSfhKDHskBh0+ZsMeLu84BnvxPTqRUFBOD+4/FRqyrGaenhXRyZFY2voom8SEBg 9KlHqbyhD+sm6ZQrDZSxEwdvqrQ9sQvEOHoiM2q/uzfU4vUqPiU= =93y8 -----END PGP SIGNATURE----- --4vLngPrEEc7/KhoN--