On Fri, Feb 28, 2025 at 05:41:17PM -0500, Jon Maloy wrote:
> v2: - Added patch breaking out udp header creation from function
>       tap_udp4_send().
>     - Updated the ICMP creation by using the new function.
>     - Added logics to find correct flow, depending on origin.
>     - All done after feedback from David Gibson.
> v3: - More changes after feedback from David Gibson.
> v4: - Even more changes after feedback from D. Gibson
> v5: - Added corresponding patches for IPv6
> v6: - Fixed some small nits after comments from D. Gibson.
> v7: - Added handling of all rejected ICMP messages
>     - Returning correct user data amount if IPv6 as per RFC 4884.
> v8: - Added MTU to ICMPv4 ICMP_FRAG_NEEDED messages.
>     - Added ASSERT() validation to message creation functions.

The whole series LGTM now.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson