From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=RO6caz6D; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 844155A0631 for ; Mon, 03 Mar 2025 04:00:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1740970813; bh=+OnlKUInUyWGXF7QpbPaqeBH7AD/esp/XZ+/fHvXWGQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RO6caz6D6IYUGmUw0rSD47F8dQLPY5DIDUD/7TO6FRn0ydjt/NfZKN1yYsipa/5If by+TwDD5z7AuCFdZtiSHSPBDbBuQoqGI8KWD9VdZEXTrueqCXsF+DnLdEvkjQuh+U3 3Rl3Rh0XedhStTS/5XhyEVybehA/KaFuH69jJI4OT0VkbyJEpYmfBXbxAXFP2gnaba BtXcskGTb4qwAZfqi81TQSWNow9CBk+WEYAVmYSKluc/eBg/VsbQghpD9ZQjgk8s6g NYdqUPufMj+ccp8cA4KHTHkNI0MHj9QDVS8NkNw4779Ak5Dt6eXE1QuemmYtv4S1b8 ua4jTC24kFfAQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Z5k7x07vLz4wcy; Mon, 3 Mar 2025 14:00:13 +1100 (AEDT) Date: Mon, 3 Mar 2025 13:49:40 +1100 From: David Gibson To: Jon Maloy Subject: Re: [PATCH v8 0/4] Reconstruct incoming ICMP headers for failed UDP connect and forward back Message-ID: References: <20250228224121.815201-1-jmaloy@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TsiEcJ/Zq0pJ9ooa" Content-Disposition: inline In-Reply-To: <20250228224121.815201-1-jmaloy@redhat.com> Message-ID-Hash: K4OEVWSEBH7JXXVYAZD2BXUTDE2JIUHP X-Message-ID-Hash: K4OEVWSEBH7JXXVYAZD2BXUTDE2JIUHP X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com, lvivier@redhat.com, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --TsiEcJ/Zq0pJ9ooa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 28, 2025 at 05:41:17PM -0500, Jon Maloy wrote: > v2: - Added patch breaking out udp header creation from function > tap_udp4_send(). > - Updated the ICMP creation by using the new function. > - Added logics to find correct flow, depending on origin. > - All done after feedback from David Gibson. > v3: - More changes after feedback from David Gibson. > v4: - Even more changes after feedback from D. Gibson > v5: - Added corresponding patches for IPv6 > v6: - Fixed some small nits after comments from D. Gibson. > v7: - Added handling of all rejected ICMP messages > - Returning correct user data amount if IPv6 as per RFC 4884. > v8: - Added MTU to ICMPv4 ICMP_FRAG_NEEDED messages. > - Added ASSERT() validation to message creation functions. The whole series LGTM now. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --TsiEcJ/Zq0pJ9ooa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmfFGLoACgkQzQJF27ox 2GdQUg/455TVNkGhlHKkafKGWZfRorP6Z26Cwkn348whG/0q/AOf6LXkAtl8KhXh 7t6oMiHamPgU+jAMTYY7q6+rfMrs4BnDpOA5I/vtkrSSJ12Mz19lrtViPA/hatpC w8Trcf0KH2rluHuvNOqF83bcwaciEhGaFLO7Ym9nmgdBrbRw+VKJflvpqhAfj1Y+ ZcaU8V41hAT2Lxok4LVYChKZ/5BTahHeIya6KzCwABznDD7+bH+Wa8FjQFxyF6BR t8I/nhrd2LtkXNaLKRSdMX8uYGdRi5R0E6JSFIXUMiDynEhAhYOcaOunjdk3TWLk iR8peVD5rAI9MHRjBcpsVogwoCsu6wxYlpA8zSFNS/3lbJdIWPRJ6eg13K6aMNVS EHS/aNi0+llmUMcWjinAfh5PRwAeIZLk+gJpK7S2GB0EDiq7ZkIHiKLdQ1dLWxH1 lanhRuHMtNh7mqvR4wOkFlXs9g1/xRlGEcKSKH3mgjlTvdlXszT7Z7Zf5XDWJZDw JlDjHmmW8UDfSrZXMVyPAE5UQhgh9OuCO4/mpsa88WHc/8oFT4tmaglLRltDKsfT kKoQrCCFcOf2fG9K2HD9oQcZppeoKU7Yt/ulam/096/hlMoK8P7jTmyb9GJZhzQG gNZ6jpNoVGxLTBg7FL5yYamqMYxH9FdCns2F9SRXkAHUhlS6wA== =q6YV -----END PGP SIGNATURE----- --TsiEcJ/Zq0pJ9ooa--