From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top, David Gibson <dgibson@redhat.com>
Subject: Re: [PATCH 6/9] tap: Use explicit defines for maximum length of L2 frame
Date: Wed, 12 Mar 2025 11:56:13 +1100 [thread overview]
Message-ID: <Z9DbrSTngJ4Es5Y7@zatzit> (raw)
In-Reply-To: <20250311234509.00badc22@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
On Tue, Mar 11, 2025 at 11:45:09PM +0100, Stefano Brivio wrote:
> Nits only (I can fix it all up on merge):
Actually, I spotted one other small change I'd like to make here, so I
might as well respin.
> On Tue, 11 Mar 2025 17:03:15 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
[snip]
> > + */
> > +#define L2_MAX_LEN_PASTA USHRT_MAX
> > +
> > +/** L2_MAX_LEN_PASST - Maximum frame length for passt mode (with L2 header)
> > + *
> > + * The only structural limit the Qemu socket protocol imposes on frames is
>
> QEMU
For some reason, the standard style for capitalizing QEMU never sticks
in my head.
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-03-12 0:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 6:03 [PATCH 0/9] Improve handling of MTU limits David Gibson
2025-03-11 6:03 ` [PATCH 1/9] conf: Use the same optstring for passt and pasta modes David Gibson
2025-03-11 6:03 ` [PATCH 2/9] conf: Move mode detection into helper function David Gibson
2025-03-11 6:03 ` [PATCH 3/9] conf: Detect vhost-user mode earlier David Gibson
2025-03-11 22:45 ` Stefano Brivio
2025-03-12 0:48 ` David Gibson
2025-03-11 6:03 ` [PATCH 4/9] packet: Give explicit name to maximum packet size David Gibson
2025-03-11 6:03 ` [PATCH 5/9] packet: Remove redundant TAP_BUF_BYTES define David Gibson
2025-03-11 6:03 ` [PATCH 6/9] tap: Use explicit defines for maximum length of L2 frame David Gibson
2025-03-11 22:45 ` Stefano Brivio
2025-03-12 0:56 ` David Gibson [this message]
2025-03-11 6:03 ` [PATCH 7/9] Simplify sizing of pkt_buf David Gibson
2025-03-11 6:03 ` [PATCH 8/9] pcap: Correctly set snaplen based on tap backend type David Gibson
2025-03-11 6:03 ` [PATCH 9/9] conf: Limit maximum MTU based on backend frame size David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9DbrSTngJ4Es5Y7@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).