From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=iTJv8ra8; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 298A65A0008 for ; Wed, 12 Mar 2025 01:57:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1741741022; bh=PMEHC1TOaIOzoJ2SFqPtOok8459ivwHtkZkqulVmxcE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iTJv8ra8hVj+IOjMJ9klKAfzDiAFH+BPlzIXur0pFWzngRtR50n2M+BCw6LZ1Lgzq 1OXKH3CNB8CzLLhwCGJlFYFi142PSKc0EprjusGmxxjx+J7kQ9afdBNHgmVamkkC2/ c3sQ6ky5LQA7rPQdbv5mNUIusv4rqHZzyOeI6c7yKqJEBnWgu9WAmDmr4pqoEIDg6P 1ukVA94ApPQ/fg7MZbKx0kW3YuDDCZ5JBJO5G3Rt9azSBDHTwavVNpBAApIgteFjku l4I6XUGqGQOVA3RySlbcPvVI31Lo6P1Czw2FWDM5n9uMH3lhBKVUtZJe3Xk9c6OLev J2a88tVcA5qfw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ZCBzf0zfhz4wyh; Wed, 12 Mar 2025 11:57:02 +1100 (AEDT) Date: Wed, 12 Mar 2025 11:56:13 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 6/9] tap: Use explicit defines for maximum length of L2 frame Message-ID: References: <20250311060318.1502861-1-david@gibson.dropbear.id.au> <20250311060318.1502861-7-david@gibson.dropbear.id.au> <20250311234509.00badc22@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MjR9QvcNxIvDVoxb" Content-Disposition: inline In-Reply-To: <20250311234509.00badc22@elisabeth> Message-ID-Hash: Z22AHKUMZX42H3GKSRHLIL4VHVNF4ZZU X-Message-ID-Hash: Z22AHKUMZX42H3GKSRHLIL4VHVNF4ZZU X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --MjR9QvcNxIvDVoxb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 11, 2025 at 11:45:09PM +0100, Stefano Brivio wrote: > Nits only (I can fix it all up on merge): Actually, I spotted one other small change I'd like to make here, so I might as well respin. > On Tue, 11 Mar 2025 17:03:15 +1100 > David Gibson wrote: [snip] > > + */ > > +#define L2_MAX_LEN_PASTA USHRT_MAX > > + > > +/** L2_MAX_LEN_PASST - Maximum frame length for passt mode (with L2 he= ader) > > + * > > + * The only structural limit the Qemu socket protocol imposes on frame= s is >=20 > QEMU For some reason, the standard style for capitalizing QEMU never sticks in my head. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --MjR9QvcNxIvDVoxb Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIyBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmfQ26wACgkQzQJF27ox 2Gelxw/0CMaWg27nfxf0doWabLAJYTohrHgvwRjvhsbLFTvUcGvUnz/UWKcLNYp6 HdJ7z4Lwg3kWb9gxOCewvLNwRz1t4KzRGoDHB/NVaNZxDegCepJCdMEgrac2SPHf 2Egeez/jLEm5YQKFsS9Wh4J1qzpy7qkVVBDyVmKBrwJk/191FoxbHBjIFZeWEbuY oBOoV0w0xEV0ci/2yFBfIzv/1yBen7u1Ocmy8Ig8ZSECtkX28i9/VpWNtOVISUyJ SYoCiIlaL+vIXihkZXIIPCl9UOfFwzZd6S+e1J9XlY0in3NqEdwnWY/DeEqu1XIZ ITOreSIWD00FPxAXlig8rSwitSHxgyPL8sWrPodbgNU0ttjQ3g/K+noAC+ywieB2 Nmn9RNWnnEhmEFV6z/bflddmVKYts8ufsa/Kai4puL7paC5eBJ+Ho2iywp26TCv5 2RdQcRGBkxPgcHHrjW2vxHeaRF5TNb95D36wNL2LRu+XmSlIdIOJr4CxC0AGX4If 2NLGngEH8n8DHgLDeOs7LxNYIgLGr2jA4r3YQmr5ZLl6bVtTCpexvIygXURXUzix XTAor2dSwovycpF0qLNndhQZBplv0bfknuHDZAUlFaLwYDOk+4v+nt9nFblYW/ni Oc59hlTfcU4nm0nP4RjCQN//1XXHcAMhVbeVyINtk4MpyFxQeQ== =G7Jv -----END PGP SIGNATURE----- --MjR9QvcNxIvDVoxb--