From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] Makefile: Enable -Wformat-security
Date: Thu, 20 Mar 2025 11:15:20 +1100 [thread overview]
Message-ID: <Z9teGMCGZYQPbZ_R@zatzit> (raw)
In-Reply-To: <20250319194755.3217105-1-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]
On Wed, Mar 19, 2025 at 08:47:55PM +0100, Stefano Brivio wrote:
> It looks like an easy win to prevent a number of possible security
> flaws.
>
> Suggested-by: David Gibson <david@gibson.dropbear.id.au>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index f2ac8e5..31cbac3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -29,7 +29,7 @@ ifeq ($(shell $(CC) -O2 -dM -E - < /dev/null 2>&1 | grep ' _FORTIFY_SOURCE ' > /
> FORTIFY_FLAG := -D_FORTIFY_SOURCE=2
> endif
>
> -FLAGS := -Wall -Wextra -Wno-format-zero-length
> +FLAGS := -Wall -Wextra -Wno-format-zero-length -Wformat-security
> FLAGS += -pedantic -std=c11 -D_XOPEN_SOURCE=700 -D_GNU_SOURCE
> FLAGS += $(FORTIFY_FLAG) -O2 -pie -fPIE
> FLAGS += -DPAGE_SIZE=$(shell getconf PAGE_SIZE)
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-03-20 1:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 19:47 [PATCH] Makefile: Enable -Wformat-security Stefano Brivio
2025-03-20 0:15 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9teGMCGZYQPbZ_R@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).