On Wed, Mar 19, 2025 at 08:47:55PM +0100, Stefano Brivio wrote:
> It looks like an easy win to prevent a number of possible security
> flaws.
> 
> Suggested-by: David Gibson <david@gibson.dropbear.id.au>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index f2ac8e5..31cbac3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -29,7 +29,7 @@ ifeq ($(shell $(CC) -O2 -dM -E - < /dev/null 2>&1 | grep ' _FORTIFY_SOURCE ' > /
>  FORTIFY_FLAG := -D_FORTIFY_SOURCE=2
>  endif
>  
> -FLAGS := -Wall -Wextra -Wno-format-zero-length
> +FLAGS := -Wall -Wextra -Wno-format-zero-length -Wformat-security
>  FLAGS += -pedantic -std=c11 -D_XOPEN_SOURCE=700 -D_GNU_SOURCE
>  FLAGS +=  $(FORTIFY_FLAG) -O2 -pie -fPIE
>  FLAGS += -DPAGE_SIZE=$(shell getconf PAGE_SIZE)

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson