From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=hqPdvejA; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 2E68E5A0271 for ; Thu, 20 Mar 2025 02:50:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1742435409; bh=8sSklW1FpS7ZirpQlc5vVZuDQTNAXB1G8/cQ8488xik=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hqPdvejAFM/oXKtRhY/YstGoNAHiCg0DF+AUahjSalLIBws9W+oc060drmMl/teAu 1zziof1TI98N4Zve3Zt+460B3gUayVDbBleZ+zCLJ4wzsmhGT+VLmMqva+aXhAtoRD N6IUNq86JFtBNjD1+3qxPrnNoapV1RAeC/pO8kRevGOw6UekWiii+P6d/mfyMmplu8 zvou7zrvJEsJ6GHseik2bH9jxD+uSmwbTUlzbY0Ghny8wA+fnpBUlPdvePCq8+Y51h 7s691iKjagXZnLYg3F9vcWLAH6wUgFoB9mkDY64zLLagSh1Kz9DXJxUla5EG/dEG97 /7I+HSomwSQSg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ZJ7nF5gLfz4x2g; Thu, 20 Mar 2025 12:50:09 +1100 (AEDT) Date: Thu, 20 Mar 2025 11:15:20 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] Makefile: Enable -Wformat-security Message-ID: References: <20250319194755.3217105-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q+liIkzQKbEqTe3m" Content-Disposition: inline In-Reply-To: <20250319194755.3217105-1-sbrivio@redhat.com> Message-ID-Hash: 2BBRA5KNF4WHTZUQSERSWGJAHBLYQAFX X-Message-ID-Hash: 2BBRA5KNF4WHTZUQSERSWGJAHBLYQAFX X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --Q+liIkzQKbEqTe3m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 19, 2025 at 08:47:55PM +0100, Stefano Brivio wrote: > It looks like an easy win to prevent a number of possible security > flaws. >=20 > Suggested-by: David Gibson > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Makefile b/Makefile > index f2ac8e5..31cbac3 100644 > --- a/Makefile > +++ b/Makefile > @@ -29,7 +29,7 @@ ifeq ($(shell $(CC) -O2 -dM -E - < /dev/null 2>&1 | gre= p ' _FORTIFY_SOURCE ' > / > FORTIFY_FLAG :=3D -D_FORTIFY_SOURCE=3D2 > endif > =20 > -FLAGS :=3D -Wall -Wextra -Wno-format-zero-length > +FLAGS :=3D -Wall -Wextra -Wno-format-zero-length -Wformat-security > FLAGS +=3D -pedantic -std=3Dc11 -D_XOPEN_SOURCE=3D700 -D_GNU_SOURCE > FLAGS +=3D $(FORTIFY_FLAG) -O2 -pie -fPIE > FLAGS +=3D -DPAGE_SIZE=3D$(shell getconf PAGE_SIZE) --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --Q+liIkzQKbEqTe3m Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmfbXfAACgkQzQJF27ox 2GcRMw//Q/u+hKgsXvU5eDgANZpgQ2LKIzGdgLnKn45oxVpSDSAQJpE51et0XNSj jSZtERvIa8bCTrTTYmBOR5ORzKDTIooCB2PWye61+5KiJahzNt3AhXtLLzzD1BRD G+ftmQsFhIFXzdBlKhNdl7vdVDGg8QQKFrL0NhPUdVLXl41NhndSDOcM966H0/JP izqA7SpbV3cKkGCaaoiSy83B9lNtvr8FW1R4epwDaXAdrS//DSO5yJ3UfukuGnpU cphII7HRsFLzI0Au7Q8xoBGXnaNFMvD6s1nxoBpj7xI7F/I4tSq/fL06GfjelcAo 1rpFtJWTQqKpfOi3OmDfSbep4V2LiT1IxRKkia9uNZ2jDfa1/vu5i4hsR4XhNePL 2Vn+AXmAnrjEhP12RTUiBp2y5UIMOltuHzyqgDCDr3EsAKrMZottLU+yMgS7cUJ4 6kdCtmCicXdGGTa9g7vjQhH1MyG+eLLnjhFQZkzkqRoS9XI8pX9tx0vhINyv2rLc 4vzPO13fGMfkldGpT9VET6HqOwADh8wO63NN46l9/Pja/QMgKDTRd8hlBiBqzthp m9q04l+uBfjG+tnc6PUtQwfPxLAOsquKdvvwIZl5fE8S79UlLbBgrG4UfBMwnQSi n/fI5mLIwa7Gw6aX5sVxwioDQFVEQAW1fSMPCHONyQMMZSq1Uso= =uGB5 -----END PGP SIGNATURE----- --Q+liIkzQKbEqTe3m--