From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] conf: Include libgen.h for basename(), fix build against musl
Date: Thu, 20 Mar 2025 11:16:02 +1100 [thread overview]
Message-ID: <Z9teQnDdGLbm8Gfe@zatzit> (raw)
In-Reply-To: <20250319194742.3216983-1-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 801 bytes --]
On Wed, Mar 19, 2025 at 08:47:42PM +0100, Stefano Brivio wrote:
> Fixes: 4b17d042c7e4 ("conf: Move mode detection into helper function")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> conf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/conf.c b/conf.c
> index 0e2e8dc..b54c55d 100644
> --- a/conf.c
> +++ b/conf.c
> @@ -16,6 +16,7 @@
> #include <errno.h>
> #include <fcntl.h>
> #include <getopt.h>
> +#include <libgen.h>
> #include <string.h>
> #include <sched.h>
> #include <sys/types.h>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-03-20 1:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 19:47 [PATCH] conf: Include libgen.h for basename(), fix build against musl Stefano Brivio
2025-03-20 0:16 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9teQnDdGLbm8Gfe@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).