From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])
	by passt.top (Postfix) with ESMTPS id 705435A0262
	for <passt-dev@passt.top>; Wed,  8 Mar 2023 23:45:13 +0100 (CET)
Received: by gandalf.ozlabs.org (Postfix, from userid 1007)
	id 4PX6pF6Fs8z4xDw; Thu,  9 Mar 2023 09:45:09 +1100 (AEDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=gibson.dropbear.id.au; s=201602; t=1678315509;
	bh=nfCz1DWwlXtu1nPPx48LxxkRW4djMHHiWs8L3HLYlnw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=ZfbBC/r+0rLPv0okrUEKO5jXQ9BcS6UApMPwzzBqTO3piktVG6rQNcF1DkEwevSVI
	 urlw+B8i3NVObSnZNJWU0pm3BkjJc7hVe+1eqd7sOEJqPCpuyAK6cI/60k1T7Kt4Mg
	 NVYrJLZrddZ9CSZArDz9od9LZ9akqe3Ykw05P0iM=
Date: Thu, 9 Mar 2023 09:11:08 +1100
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH 3/4] treewide: Fix header includes to build with musl
Message-ID: <ZAkH/N5PhUeoQXGD@yekko>
References: <20230308073516.2189680-1-sbrivio@redhat.com>
 <20230308073516.2189680-4-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="6k+ADtMjAFESyuPm"
Content-Disposition: inline
In-Reply-To: <20230308073516.2189680-4-sbrivio@redhat.com>
Message-ID-Hash: 4BFXI7J2BX363RTUMM6FP4SGN6MIAKFJ
X-Message-ID-Hash: 4BFXI7J2BX363RTUMM6FP4SGN6MIAKFJ
X-MailFrom: dgibson@gandalf.ozlabs.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: passt-dev@passt.top, Chris Kuhn <kuhnchris+passt@kuhnchris.eu>, lemmi <lemmi@nerd2nerd.org>
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/ZAkH/N5PhUeoQXGD@yekko/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/4BFXI7J2BX363RTUMM6FP4SGN6MIAKFJ/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>


--6k+ADtMjAFESyuPm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 08, 2023 at 08:35:15AM +0100, Stefano Brivio wrote:
> From: Chris Kuhn <kuhnchris+github@kuhnchris.eu>
>=20
> Roughly inspired from a patch by Chris Kuhn: fix up includes so that
> we can build against musl: glibc is more lenient as headers generally
> include a larger amount of other headers.
>=20
> Compared to the original patch, I only included what was needed
> directly in C files, instead of adding blanket includes in local
> header files. It's a bit more involved, but more consistent with the
> current (not ideal) situation.

Best I can tell, there's no ideal way to manage C includes :/.

> Reported-by: Chris Kuhn <kuhnchris+github@kuhnchris.eu>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  conf.c       | 2 ++
>  isolation.c  | 1 +
>  netlink.c    | 1 +
>  passt.c      | 2 ++
>  tap.c        | 1 +
>  tcp.c        | 1 +
>  tcp_splice.c | 1 +
>  udp.c        | 1 +
>  util.c       | 1 +
>  9 files changed, 11 insertions(+)
>=20
> diff --git a/conf.c b/conf.c
> index 07b0b7b..582c391 100644
> --- a/conf.c
> +++ b/conf.c
> @@ -23,8 +23,10 @@
>  #include <limits.h>
>  #include <grp.h>
>  #include <pwd.h>
> +#include <signal.h>
>  #include <stdlib.h>
>  #include <stdint.h>
> +#include <stdio.h>
>  #include <stdbool.h>
>  #include <unistd.h>
>  #include <syslog.h>
> diff --git a/isolation.c b/isolation.c
> index 6bae4d4..20dc879 100644
> --- a/isolation.c
> +++ b/isolation.c
> @@ -65,6 +65,7 @@
>  #include <stdbool.h>
>  #include <stddef.h>
>  #include <stdlib.h>
> +#include <stdio.h>
>  #include <string.h>
>  #include <time.h>
>  #include <unistd.h>
> diff --git a/netlink.c b/netlink.c
> index 0e0be4f..c8d39a1 100644
> --- a/netlink.c
> +++ b/netlink.c
> @@ -18,6 +18,7 @@
>  #include <errno.h>
>  #include <sys/types.h>
>  #include <limits.h>
> +#include <signal.h>
>  #include <stdlib.h>
>  #include <stdbool.h>
>  #include <stdint.h>
> diff --git a/passt.c b/passt.c
> index f67213a..dfec9d4 100644
> --- a/passt.c
> +++ b/passt.c
> @@ -27,6 +27,8 @@
>  #include <stdlib.h>
>  #include <unistd.h>
>  #include <netdb.h>
> +#include <signal.h>
> +#include <stdio.h>
>  #include <string.h>
>  #include <errno.h>
>  #include <time.h>
> diff --git a/tap.c b/tap.c
> index 88eed88..15fb52e 100644
> --- a/tap.c
> +++ b/tap.c
> @@ -14,6 +14,7 @@
>   */
> =20
>  #include <sched.h>
> +#include <signal.h>
>  #include <stdio.h>
>  #include <errno.h>
>  #include <limits.h>
> diff --git a/tcp.c b/tcp.c
> index 8e8d653..96ca5c7 100644
> --- a/tcp.c
> +++ b/tcp.c
> @@ -267,6 +267,7 @@
>  #include <sched.h>
>  #include <fcntl.h>
>  #include <stdio.h>
> +#include <signal.h>
>  #include <stdlib.h>
>  #include <errno.h>
>  #include <limits.h>
> diff --git a/tcp_splice.c b/tcp_splice.c
> index 67af46b..6559762 100644
> --- a/tcp_splice.c
> +++ b/tcp_splice.c
> @@ -32,6 +32,7 @@
>   */
> =20
>  #include <sched.h>
> +#include <signal.h>
>  #include <errno.h>
>  #include <fcntl.h>
>  #include <limits.h>
> diff --git a/udp.c b/udp.c
> index 99cfc9f..1077cde 100644
> --- a/udp.c
> +++ b/udp.c
> @@ -91,6 +91,7 @@
>   */
> =20
>  #include <sched.h>
> +#include <signal.h>
>  #include <stdio.h>
>  #include <errno.h>
>  #include <limits.h>
> diff --git a/util.c b/util.c
> index 799173f..484889b 100644
> --- a/util.c
> +++ b/util.c
> @@ -13,6 +13,7 @@
>   */
> =20
>  #include <sched.h>
> +#include <stdio.h>
>  #include <stdlib.h>
>  #include <unistd.h>
>  #include <arpa/inet.h>

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--6k+ADtMjAFESyuPm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmQJB/YACgkQzQJF27ox
2GcQhQ/+M7GCoZBjPxtewH9KOpHaCgpXyXRU+hu7swaZTVC7xOwxCrf1ozYWvZjN
GJCsmmW76WPPsXAJawPMeGQLi3WCArz4mZwen11+G5SXI3042M8XYQZmykl5oCsy
Wai5AfbGIUA86XEkyjVY8CSahrPRcinbM8O4v9LoCmTNE+34Qh458VBSt98Dv5rv
X6yvwg2a8fI00qa7qYIPUEtbd6MGhRKV7ETDTvoe4zX2xn38PIcsWKFXiMyMVAdZ
zxGltwbT1VwOhNtTSY7pptkjkFIi36yTxbmjp3MkZ+AlO0bXlkHPQLUAkD1ip21n
xStrNWOxL7rCca3k4NzBgD+jIR8CMCTYgfz5vG355RrwUFtMnejJsdiiL10EcXGp
MrQ4bZV19dXR9dRKYPZTJ2mT01jKmqpudGuXWVu0B1yDEJi2lhf/+WHlPZjNbvd+
iQPz7ODgOKflCI9+Hk06s+prtTDl3kP58R5KyqBTKsTayHjKvqXMXGtQMy+OCgax
tkCr1RO6qUTNiTDcEve+FbG00yUKeO3YWXbOcgwZTh75ciw2pdrjokUY3+0ovFWN
nYdveg30qa5FMsApfyJdJUjyAUu+cvpjvzQ1fd/l6rfUhNoQZDA1nekA3icyL3v+
Um+Hqtub6xWRaJTALWcvS7ZJ51SiIyHz/GsAwQUBpwlv4aQrR4c=
=Iuj+
-----END PGP SIGNATURE-----

--6k+ADtMjAFESyuPm--