Re: [PATCH 4/4] util: Carry own definition of __bswap_constant{16,32}

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]

On Wed, Mar 08, 2023 at 08:35:16AM +0100, Stefano Brivio wrote:
> musl doesn't define those, use our own definition there. This is a
> trivial implementation, similar to what's shipped by e.g. uClibc,
> glibc, libiio.
> 
> Reported-by: Chris Kuhn <kuhnchris+github@kuhnchris.eu>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  util.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/util.h b/util.h
> index 570094c..8367f51 100644
> --- a/util.h
> +++ b/util.h
> @@ -88,6 +88,17 @@
>  #define MAC_ZERO		((uint8_t [ETH_ALEN]){ 0 })
>  #define MAC_IS_ZERO(addr)	(!memcmp((addr), MAC_ZERO, ETH_ALEN))
>  
> +#ifndef __bswap_constant_16
> +#define __bswap_constant_16(x)						\
> +	((uint16_t) ((((x) >> 8) & 0xff) | (((x) & 0xff) << 8)))
> +#endif
> +
> +#ifndef __bswap_constant_32
> +#define __bswap_constant_32(x)						\
> +	((((x) & 0xff000000) >> 24) | (((x) & 0x00ff0000) >>  8) |	\
> +	 (((x) & 0x0000ff00) <<  8) | (((x) & 0x000000ff) << 24))
> +#endif
> +
>  #if __BYTE_ORDER == __BIG_ENDIAN
>  #define	htons_constant(x)	(x)
>  #define	htonl_constant(x)	(x)

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]