From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id F15E25A0262 for ; Wed, 8 Mar 2023 23:51:40 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4PX6xl0Jxvz4xDq; Thu, 9 Mar 2023 09:51:39 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1678315899; bh=0CNqWhcsIFPKDnR950EK3je58SBuYURt3d9iXSmYiqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dxs3oqQFeT1ZhXujQCRGuXAb6h3yRUW7gLaessYpuOFCWqYJ4jvTKfVLwWxeZjyXo 7NVsB0VBG0kA3Sm3leGI4qDE1dY4NbL90Ls8pU9KTj23oCZaL9Rj8PsqAypeWBSjtt idZgPe3ZiWGhPyoV6o/GN4j0Ek5vQmnJcqKYj5QQ= Date: Thu, 9 Mar 2023 09:47:56 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v3 0/2] Implement explicit outbound address and interface selection Message-ID: References: <20230308224231.2560531-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s1DifyRjmNSk/i8/" Content-Disposition: inline In-Reply-To: <20230308224231.2560531-1-sbrivio@redhat.com> Message-ID-Hash: TAR5LTNELHTBB76U34JSM7UK3IWW2MPD X-Message-ID-Hash: TAR5LTNELHTBB76U34JSM7UK3IWW2MPD X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --s1DifyRjmNSk/i8/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 08, 2023 at 11:42:29PM +0100, Stefano Brivio wrote: > v3: In 2/2, *really* pass the correct bind_addr reference to sock_l4() in > udp_tap_handler() -- I just sent v2 from the wrong directory :/ Heh. My remaining comments from v1 still apply. >=20 > Stefano Brivio (2): > conf, passt.h: Rename "outbound" interface to "template" interface > conf, icmp, tcp, udp: Add options to bind to outbound address and > interface >=20 > conf.c | 89 +++++++++++++++++++++++++++++++++++++++++++++++++++------ > icmp.c | 24 +++++++++++++--- > passt.1 | 19 ++++++++++++ > passt.h | 14 +++++++-- > tcp.c | 60 ++++++++++++++++++++++++++++++++++++++ > udp.c | 54 +++++++++++++++++++++++----------- > 6 files changed, 228 insertions(+), 32 deletions(-) >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --s1DifyRjmNSk/i8/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmQJEJYACgkQzQJF27ox 2GfTbQ/7Bqk9u/VRnFfSB3ZGaONli9NAIo72zr7ywiwbp6N6aPbSy2xl0e6f6Vl6 ZeqdDJuN2m8U47LvgNZEyL9PUJspLT49LC4CCcuELW1oXpjmJUqWrI3hU0b7rwB8 c4mmdcvdtvKzD8uoFxFRyEKogrFD2jcqS22Jr0xjn1PX3HkvybLS3BLO0WslY9c4 CWUFTDqfGmP3uev+5v1m0RrU6n4y+DSVyXVRcceBoWIs77JLC2dKc0fJT5ABWKOB yM3PQWNb55KHyzoonTv0DjYKJ45yM4XI5QVV50ehntXU9Wckmcw6rA6SNTaX+8EX g5QxOI5h+prfbfDS+axpWc0F0EM11XY8oSghD5dlqZeGtzrw2vCgtupxxHjH2Vjx dVe0hRtLfCGur7U7WKT1oggT04P2EkmiLqEJ9nsfAFQMSLxNhbj4Hb0S7yJdrdJ+ uGrkhdx5yj8hMD9sZuFjT1uS6IcLDmU6eNrrOxvrbICJ8n6CekZOvJCYLFxIihhR 3gdOdGINGeCiM/9jlqFb5GVj5rOU9RMaLzo177e2gX52sYMzgRsL7TreMnGeSRHQ olKC5HqL6ZZxIpFUTKYNzWo38i0nzvE7xRhQkSgX5zuZV6HzpYgYUa6b6T5WRr3Y ti01vjg95Y1fvAApVj5sEdIsnex12x/TU5MkzYuPwdoRPotUWZ4= =F021 -----END PGP SIGNATURE----- --s1DifyRjmNSk/i8/--