From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id BBAC55A0272 for ; Thu, 6 Apr 2023 04:50:13 +0200 (CEST) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4PsQvz5bpbz4xDt; Thu, 6 Apr 2023 12:50:07 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1680749407; bh=ytqkxpvAAr2j6Q1lRwbwED28M8mMY33y4yFnIphBpM0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iP1/7MgvsZeAQTtqqPZlc4y+ek2rCcPxzi3MvW2X1U0hBXbfjw6v7XQQv4qRzly2a UyeghdZ0OSUnpp9Ul9Hsh4u53GaCU5ytZbcGPE5KLOyvag8i+ZnyloMxgjZfPe0YG9 jPqCEYXxSNH/z/Lwy8fGF9iBdD9nbynWC+3prdns= Date: Thu, 6 Apr 2023 10:10:09 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 03/14] nstool: Move description of its operation modes from comment to usage Message-ID: References: <20230404014638.3225556-1-david@gibson.dropbear.id.au> <20230404014638.3225556-4-david@gibson.dropbear.id.au> <20230405135648.00a7e1dc@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ik8rI+a1GKP0ZNRz" Content-Disposition: inline In-Reply-To: <20230405135648.00a7e1dc@elisabeth> Message-ID-Hash: GY754JK5R7O3VDABBAXX26WL7UZ7R5I2 X-Message-ID-Hash: GY754JK5R7O3VDABBAXX26WL7UZ7R5I2 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --ik8rI+a1GKP0ZNRz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 05, 2023 at 01:56:59PM +0200, Stefano Brivio wrote: > On Tue, 4 Apr 2023 11:46:27 +1000 > David Gibson wrote: >=20 > > Easier to see it there. > >=20 > > Signed-off-by: David Gibson > > --- > > test/nstool.c | 26 +++++++++++--------------- > > 1 file changed, 11 insertions(+), 15 deletions(-) > >=20 > > diff --git a/test/nstool.c b/test/nstool.c > > index cc6d617..7e069b6 100644 > > --- a/test/nstool.c > > +++ b/test/nstool.c > > @@ -4,20 +4,6 @@ > > * > > * Copyright Red Hat > > * Author: David Gibson > > - * > > - * Can run in 3 modes: > > - * > > - * nstool hold > > - * Designed to be run inside a namespace, opens a Unix domain > > - * control socket at and waits until instructed to stop > > - * with "nstool stop " > > - * nstool pid > > - * Prints the PID of the nstool hold process with control socket > > - * . This is given in the PID namespace where nstool pid > > - * is executed, not the one where nstool hold is running > > - * nstool stop > > - * Instruct the nstool hold with control socket at to > > - * exit. > > */ > > =20 > > #define _GNU_SOURCE > > @@ -38,7 +24,17 @@ > > =20 > > static void usage(void) > > { > > - die("Usage: nstool hold|pid|stop \n"); > > + die("Usage:\n" > > + " nstool hold SOCK\n" > > + " Run within a set of namespaces, open a Unix domain control\n" >=20 > UNIX domain socket Adjusted. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ik8rI+a1GKP0ZNRz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmQuDckACgkQzQJF27ox 2Gfh+BAAqtJLFMMC4RxawJzQZX+IcAsQs+jQAC7QcEnQshmGfbKnRTSOhkvBW3hZ 2udJaXw4K2A/D7l+CcEHimICBI2DlKaP5LBRIvq7vHYWnZPu/zA9JuF5aPsQIp1c aAL2CkQ22L0+3tb642/+OYWm00+sn9XmTXbN90a365nsHE2cqRM9O3p1/1I7p9R5 G7YksICmiedpGus5KBee8SFji1SrDAsD0TdClUEqsHkZbqc4FVMe/0O+Eq7qI7Xs rzV9lTN2yR8avB5iMVOyDarGXSJvGdv/VEXfaVxGFoC+SZoBkz8N5X5CoXqfddG9 Xsl3vo9lakR/KhIN1BSpaN3ujZeB0Hi0T37Bsc3QeVwzUmnljgr97gv9JW7AAC26 hXoLFZzYbg3r+8AiCpfPWKPm4nm+O9jGUrOLFOuafqprhlp85cQxs5Qu97voJzNN GlRLH87DZJcYYSNlqaR1meNi/ZeKqwcKnEu3/C2hmXmxTX/ocD3uGfeMaBST7a3z Lyvf5N1oKbhjMoJAGFG5BW1oLtDcjQIB06fqA4mUMgpu6rdPirlc36AVqyMxYxEG ThnUBuOYO7szIXUn/qRcJYBXmBuj6NfjroGXFp4qnQL4HgDsN3Xe9e5irks7oU+8 kPYBLvzJJIvTsdL6eUkNNcqfx/D53P2DEd2o/4p27zyYeJrCMnM= =ScNe -----END PGP SIGNATURE----- --ik8rI+a1GKP0ZNRz--