From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id D1E285A0288 for ; Tue, 16 May 2023 06:06:58 +0200 (CEST) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4QL2k45lkXz4x3x; Tue, 16 May 2023 14:06:52 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1684210012; bh=TrK+0ciQ2nS0uN21Y6whX1TdhZlHTiS4CgNMp8KNZhg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l0bgQpWlS9DR+eKkwwLPOZJXwcSQwgWYLcH9PMDWpo+8hlbieglGMIhWPxoEseZzU qJ7V9X/7zaV6+jRt2cx72AQK3ENLgLsRBpbExGvdS2zkOjkulaFRG46TfFaqFaXCEn 3bNanjX8LKP3K1mVedPeGv5gV5LkAKeaxzYvcrFI= Date: Tue, 16 May 2023 13:23:00 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 01/10] netlink: Fix comment about response buffer size for nl_req() Message-ID: References: <20230514181415.313420-1-sbrivio@redhat.com> <20230514181415.313420-2-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FQSAH8aAoVDAOGyN" Content-Disposition: inline In-Reply-To: <20230514181415.313420-2-sbrivio@redhat.com> Message-ID-Hash: MWLTEODI3DGEHWHDXEQVA4MC4WDKS2ZP X-Message-ID-Hash: MWLTEODI3DGEHWHDXEQVA4MC4WDKS2ZP X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Callum Parsey , me@yawnt.com, lemmi@nerd2nerd.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --FQSAH8aAoVDAOGyN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 14, 2023 at 08:14:06PM +0200, Stefano Brivio wrote: > Fixes: fde8004ab0b4 ("netlink: Use 8 KiB * netlink message header size as= response buffer") > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson Makes sense regardless of the rest of the series. > --- > netlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/netlink.c b/netlink.c > index b99af85..c07a13c 100644 > --- a/netlink.c > +++ b/netlink.c > @@ -99,7 +99,7 @@ fail: > /** > * nl_req() - Send netlink request and read response > * @ns: Use netlink socket in namespace > - * @buf: Buffer for response (at least BUFSIZ long) > + * @buf: Buffer for response (at least NLBUFSIZ long) > * @req: Request with netlink header > * @len: Request length > * --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --FQSAH8aAoVDAOGyN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmRi9wAACgkQzQJF27ox 2GfBqA/+NA21ky0DqxfegZ+koeopT+1CkLZd9jfMZUjk+x5XiOM9EUKy5wG6HPns HGDJ+QAhafzkURKT5eIaj1FWl763cVG0Y88oNnFZLcjY5793DYmWPN0FXXxjI5IV EXuJBeVp+fXsfJBuBLSAilS1E6NILIDYYtJFXdy0X63aY3F/ttdXE1eqNgV27qSK C2rGqoRMM5stiIR3X3DNCgJ2nA7dA85lG01kbzkELZ0b3I+8VNRB38uSpzsSXAav 6XrEeEQbkcZcuYtiQ6ee5L7M9uAQOfq2AmPIMgiNQyg55AzitLh/GgxqR4H4rD9R m0vPjyDNrZBryoTVwtQkqccvMv3rI/Uob3v5N8ZM4L+knLo/D7OvT69n6s8SvmBO AZVPcOYabrRuPgVkpTrF3EFfNwI52yq8m5WV7u10niv90xsu++Ng346t8J3I4iEN 6nysH7ON7kenka2T12rvzfV9yaOeMhQum369ljF9kNG1jY4LPyEr6aMdKRUnY32L hn7H05Y3Ayaq/HP9/ZufCoiWbRoXyBfSgfhgtxwzFxW6OCAKWe/q41qj+2OJOrrd tT/zn/BVZOCJufpYGZczxeAHK8rZzPWYfGUTUA5cUBXWM6EI3zMk+K5Ly3aigT7T fXjHCyAQkzreJtmYaHca2W5zQCNvh9Xtn1Q5y/XdIM/uFJ4D9Aw= =HKXd -----END PGP SIGNATURE----- --FQSAH8aAoVDAOGyN--