From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: KuhnChris <kuhnchris+git@kuhnchris.eu>,
passt-dev@passt.top, KuhnChris <kuhnchris@kuhnchris.eu>
Subject: Re: [PATCH] MAKE: Fix parallel builds; .o files; .gitignore; new makedocs
Date: Sun, 2 Jul 2023 20:04:08 +1000 [thread overview]
Message-ID: <ZKFLmNMV+VyMnnY0@zatzit> (raw)
In-Reply-To: <20230630191544.34acb996@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]
On Fri, Jun 30, 2023 at 07:16:19PM +0200, Stefano Brivio wrote:
> Thanks for the patch, and sorry for the delay!
>
> First off, as I was mentioning on IRC: it would help to have this as
> two/three patches -- not just because it's easier to review, but also
> because the Makefile changes have, I guess, a relatively high risk of
> introducing some regressions, so keeping it simple for 'git bisect'
> would also be a plus here.
>
> If you want to split this in your working tree, you can do something
> like:
>
> git reset HEAD~
>
> meaning: reset (the git state, not the file contents) to the commit
> before head (~ is a shortcut for "just before"). Then 'git add' your
> pieces back -- and if you have two changes to the Makefile you want to
> keep separated, go with 'git add -i', which lets you add just parts.
git citool also allows doing this interactively quite nicely. You can
move files, or individual hunks or lines between being in the commit,
or not.
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-07-03 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 14:07 [PATCH] MAKE: Fix parallel builds; .o files; .gitignore; new makedocs KuhnChris
2023-06-30 17:16 ` Stefano Brivio
2023-07-02 10:04 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKFLmNMV+VyMnnY0@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=kuhnchris+git@kuhnchris.eu \
--cc=kuhnchris@kuhnchris.eu \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).