Re: [PATCH 0/3] Better report errors failing to open namespace tap device

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Fri, Aug 04, 2023 at 09:04:46AM +0200, Stefano Brivio wrote:
> On Wed,  2 Aug 2023 13:15:39 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > In https://github.com/containers/podman/issues/19428, pasta is failing
> > to open the namespace tap device.  Paul Holzinger correctly noted that
> > pasta isn't very helpful in this case, with no information beyond "it
> > failed".  He suggested a patch for that, however it wasn't quite
> > sufficient: errno may not be propagated back from the ephemeral thread
> > which enters the namespace, and even if it does the errno alone won't
> > tell us which of the possible failure points actually failed.
> > 
> > 2/3 here is a more robust change to address the problem.  The other
> > patches are minor cleanups I noticed along the way.
> > 
> > Link: https://bugs.passt.top/show_bug.cgi?id=69
> > 
> > David Gibson (3):
> >   util: Make ns_enter() a void function and report setns() errors
> >   tap: More detailed error reporting in tap_ns_tun()
> >   tap: Remove unnecessary global tun_ns_fd
> 
> Applied, too (no, I didn't forget about the flow tracking series :) I'm
> still reviewing it).

Fair enough.  It's probably the most conceptually complex of all the
outstanding series.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]