From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id F0D575A026D for ; Fri, 4 Aug 2023 10:38:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1691138320; bh=7r3hozISzsNIyQ2edXg3rCcNb0p5RyG8zpir0Ifmjn4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PUzM4hi4WqnsbGSA2bTMeNCUUfDymSSIQL+LnLmGm7HuaOgGVR+YZw41p+fB8HmCJ dQiYopYuk/yUtVYCSlynprNptcs0u+qAnO56sFxJ7mJscAYdfTYX4w/162QMcomz3F N2MH07ZM8RVaE+Vv8xZYLRHPuNVtFnl0ZlRZt/3M= Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4RHJym3252z4wxm; Fri, 4 Aug 2023 18:38:40 +1000 (AEST) Date: Fri, 4 Aug 2023 18:35:27 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 0/3] Better report errors failing to open namespace tap device Message-ID: References: <20230802031542.2726758-1-david@gibson.dropbear.id.au> <20230804090446.59043eb5@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+y7FyygC+iI9YTRG" Content-Disposition: inline In-Reply-To: <20230804090446.59043eb5@elisabeth> Message-ID-Hash: 5BDF5AUI2K6OPYMJFI4MI4LAY7UKA3ZQ X-Message-ID-Hash: 5BDF5AUI2K6OPYMJFI4MI4LAY7UKA3ZQ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --+y7FyygC+iI9YTRG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 04, 2023 at 09:04:46AM +0200, Stefano Brivio wrote: > On Wed, 2 Aug 2023 13:15:39 +1000 > David Gibson wrote: >=20 > > In https://github.com/containers/podman/issues/19428, pasta is failing > > to open the namespace tap device. Paul Holzinger correctly noted that > > pasta isn't very helpful in this case, with no information beyond "it > > failed". He suggested a patch for that, however it wasn't quite > > sufficient: errno may not be propagated back from the ephemeral thread > > which enters the namespace, and even if it does the errno alone won't > > tell us which of the possible failure points actually failed. > >=20 > > 2/3 here is a more robust change to address the problem. The other > > patches are minor cleanups I noticed along the way. > >=20 > > Link: https://bugs.passt.top/show_bug.cgi?id=3D69 > >=20 > > David Gibson (3): > > util: Make ns_enter() a void function and report setns() errors > > tap: More detailed error reporting in tap_ns_tun() > > tap: Remove unnecessary global tun_ns_fd >=20 > Applied, too (no, I didn't forget about the flow tracking series :) I'm > still reviewing it). Fair enough. It's probably the most conceptually complex of all the outstanding series. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --+y7FyygC+iI9YTRG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmTMuDsACgkQzQJF27ox 2GcSAg/9HSSzcBNOSBWj//bahuWo8kzh5naQzey6TKW9DLDm7JhnnFJSrj05h//u YKA6ZkSs3IOlvbp2DOyddb6OTf3IZLdGeijGuYVc16rkw4vt4NaPu3vyHBh8F1uO zIogWF5hCRRYzvKcifjycSNNt1SHED1U9Stum9mmod8hQeE2ioOXOZ0L5KcYifvG o8wd4T9wLkrVdu91YxqaxTxvUP54Lry7MRiecRey4StaG/pVbtpbBRTQazq8OWeL uVY8+3knByr43bXMceKoOa2GCoM9TjP8rE/ImSalLjX/wGvK5suPPWjjAmndMDKb W9QLq/vNSnVDAvsKidJQyu3RRjDNeqnDVh7+YdcwvxMQIMUPCZ4UaqI6DTBrvr4r 2tEOc3Cx/X4D1DyZboGZ7LRyDWRRHHu0LoxR1m5j/Eonz3eypWilghQLH3POqvYN o3kU7ZD5V6pp/+5d1lAxYaGq2rnh86cFJY/Y25MqrUV/3trTFSFsWwNXg304o2Ca sdCTMgJ22AhuCx3q2dsBBUY/RkdEZ8Dm1BHiJ5pVVai/yqktmS5jw47G+BQ+2VR9 wMvyvv1nRRxYBXdZurlYAJDYf/iUqpmtpp96f/fdimPePkNDosKyzu7Bz2awcLG9 uEhnKcBVUEU7GMKAAXcJowp74oqIz2k3vXyMsz23XQz8h0NbwlQ= =ePUY -----END PGP SIGNATURE----- --+y7FyygC+iI9YTRG--