From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id EDD015A026F for ; Thu, 17 Aug 2023 05:37:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1692243455; bh=bf/DBO4F53eQ4Lxr0NlezQ/W0n0Jr6/tHTN6XxzFDu0=; h=Date:From:To:Subject:References:In-Reply-To:From; b=ActIkaXsyp6+W9POSs+GimKvNvqEkBKHjk5/v57ekToCkUYl8/9zbk9HQQNk/wV/b dGnWMy2tsXfLRZbwzgxmzxoY1ijll14wlRdYa3wZZ++j+7K7IO8tIjutMBE7j2ybZX Ke/F+YTxAO+LJ066oga/EotNgA45H2FtbAQYkMPE= Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4RR9gM1dVmz4wy3; Thu, 17 Aug 2023 13:37:35 +1000 (AEST) Date: Thu, 17 Aug 2023 13:37:13 +1000 From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: Re: [PATCH v2 0/7] Flow Table Preliminaries Message-ID: References: <20230811125405.1364340-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8H3GHMDN89wgpja/" Content-Disposition: inline In-Reply-To: <20230811125405.1364340-1-david@gibson.dropbear.id.au> Message-ID-Hash: GL4B54RKFH4H2PC52XCOD5ZLXMOCC2VB X-Message-ID-Hash: GL4B54RKFH4H2PC52XCOD5ZLXMOCC2VB X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --8H3GHMDN89wgpja/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 11, 2023 at 10:53:58PM +1000, David Gibson wrote: > I'm still working on bunch of things to start implementing the > generalised flow table. However, I think this set of preliminary > clean ups and fixes stand well enough on their own that they're ready > for merge now. >=20 > Based on the epoll patch series. JSYK, I will be sending another spin of this, with at least 2 additional patches. The only changes I'm anticipating in the existing patches is a trivial formatting tweak, so it shouldn't invalidate review on this version. > Changes since v1: > * Add missing patch moving in_epoll flag >=20 > David Gibson (7): > tap: Don't clobber source address in tap6_handler() > tap: Pass source address to protocol handler functions > tcp: More precise terms for addresses and ports > tcp: Consistent usage of ports in tcp_seq_init() > tcp, udp: Don't include destination address in partially precomputed > csums > tcp, udp: Don't pre-fill IPv4 destination address in headers > tcp: Move in_epoll flag out of common connection structure >=20 > icmp.c | 12 ++-- > icmp.h | 3 +- > passt.c | 10 ++- > passt.h | 4 +- > pasta.c | 2 +- > tap.c | 29 ++++---- > tcp.c | 194 +++++++++++++++++++++++---------------------------- > tcp.h | 5 +- > tcp_conn.h | 18 ++--- > tcp_splice.c | 4 +- > udp.c | 37 ++++------ > udp.h | 5 +- > util.h | 4 +- > 13 files changed, 151 insertions(+), 176 deletions(-) >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --8H3GHMDN89wgpja/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmTdldMACgkQzQJF27ox 2GeTEg/+MRSLc++B/FLknUIDqJ0Dq9lqf9Uz3efUSEJgcJU8l+wHjQa+oWwZeZK5 FzLO0IBjpAbPuovzBvZs0x2A24QCj3eZI6ataTvOBr1SbDSVTeYTj3x7A40sIPYy q9e2vAkqjISECFHFQrW/XzH4R1Mno96lFMVL8azLnOr72mT4JoO3HKcuXkJU6eyX a5tLvF+X4Jj3+pgvL1iu7rBh1g1LI1rkaclP0TvHLAOSjfmyZgHc+wNvcbuVU5AY Siy8g3weHHhyiLV3zMmoODMEtiDv26Vc6kOfQx+c8DHOHnSgPQOfGSfl1uTVnr3A Rtag28JUZU/OUgOz+j/LOHZd7RqJTB9QI9aHieX40CezjvPInzjKeg1j0bvnpUHG TokWVl6kWsIBLpRFHGJ/CnlmiG/TRSwKM+FRweLrj3JzYBVKhEbhWQTjhf/G5oy0 H7XGuL/HxkQ1zu46vLSd8gwERW97XCk31xAxuBBFx5hr1VI0qgYYjiv/foo6yHix 8VEZ0sDrzFDO5mvjaD+kfo2OcFmFgsi1DWYcaOE9we+1weSmZUxtUnrPdGFE7kQ1 VceHbzJuYpgMAGYfj1ptlG0R2UNQTUTbgLqY8z16SeID8JOQuQez8sCD3d2LBzpv HlkbFvVr/PIqXJrGlikl28sttjZqDlm+LZ/KffjA1tiwA0y9rqk= =ooLr -----END PGP SIGNATURE----- --8H3GHMDN89wgpja/--