From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] tap: Fix format specifier in tap4_is_fragment() warning
Date: Wed, 16 Aug 2023 16:58:07 +1000 [thread overview]
Message-ID: <ZNxzf9yTa3mvnqcB@zatzit> (raw)
In-Reply-To: <20230816062623.883685-1-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]
On Wed, Aug 16, 2023 at 08:26:23AM +0200, Stefano Brivio wrote:
> Spotted by Coverity, relatively harmless.
>
> Fixes: e01759e2fab0 ("tap: Explicitly drop IPv4 fragments, and give a warning")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> tap.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tap.c b/tap.c
> index a6f8692..760deb7 100644
> --- a/tap.c
> +++ b/tap.c
> @@ -561,7 +561,8 @@ static bool tap4_is_fragment(const struct iphdr *iph,
>
> num_dropped++;
> if (now->tv_sec - last_message > FRAGMENT_MSG_RATE) {
> - warn("Can't process IPv4 fragments (%lu dropped)", num_dropped);
> + warn("Can't process IPv4 fragments (%u dropped)",
> + num_dropped);
> last_message = now->tv_sec;
> num_dropped = 0;
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-08-16 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 6:26 [PATCH] tap: Fix format specifier in tap4_is_fragment() warning Stefano Brivio
2023-08-16 6:58 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNxzf9yTa3mvnqcB@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).