public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
* [PATCH] tap: Fix format specifier in tap4_is_fragment() warning
@ 2023-08-16  6:26 Stefano Brivio
  2023-08-16  6:58 ` David Gibson
  0 siblings, 1 reply; 2+ messages in thread
From: Stefano Brivio @ 2023-08-16  6:26 UTC (permalink / raw)
  To: passt-dev; +Cc: David Gibson

Spotted by Coverity, relatively harmless.

Fixes: e01759e2fab0 ("tap: Explicitly drop IPv4 fragments, and give a warning")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 tap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tap.c b/tap.c
index a6f8692..760deb7 100644
--- a/tap.c
+++ b/tap.c
@@ -561,7 +561,8 @@ static bool tap4_is_fragment(const struct iphdr *iph,
 
 		num_dropped++;
 		if (now->tv_sec - last_message > FRAGMENT_MSG_RATE) {
-			warn("Can't process IPv4 fragments (%lu dropped)", num_dropped);
+			warn("Can't process IPv4 fragments (%u dropped)",
+			     num_dropped);
 			last_message = now->tv_sec;
 			num_dropped = 0;
 		}
-- 
@@ -561,7 +561,8 @@ static bool tap4_is_fragment(const struct iphdr *iph,
 
 		num_dropped++;
 		if (now->tv_sec - last_message > FRAGMENT_MSG_RATE) {
-			warn("Can't process IPv4 fragments (%lu dropped)", num_dropped);
+			warn("Can't process IPv4 fragments (%u dropped)",
+			     num_dropped);
 			last_message = now->tv_sec;
 			num_dropped = 0;
 		}
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tap: Fix format specifier in tap4_is_fragment() warning
  2023-08-16  6:26 [PATCH] tap: Fix format specifier in tap4_is_fragment() warning Stefano Brivio
@ 2023-08-16  6:58 ` David Gibson
  0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2023-08-16  6:58 UTC (permalink / raw)
  To: Stefano Brivio; +Cc: passt-dev

[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]

On Wed, Aug 16, 2023 at 08:26:23AM +0200, Stefano Brivio wrote:
> Spotted by Coverity, relatively harmless.
> 
> Fixes: e01759e2fab0 ("tap: Explicitly drop IPv4 fragments, and give a warning")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  tap.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tap.c b/tap.c
> index a6f8692..760deb7 100644
> --- a/tap.c
> +++ b/tap.c
> @@ -561,7 +561,8 @@ static bool tap4_is_fragment(const struct iphdr *iph,
>  
>  		num_dropped++;
>  		if (now->tv_sec - last_message > FRAGMENT_MSG_RATE) {
> -			warn("Can't process IPv4 fragments (%lu dropped)", num_dropped);
> +			warn("Can't process IPv4 fragments (%u dropped)",
> +			     num_dropped);
>  			last_message = now->tv_sec;
>  			num_dropped = 0;
>  		}

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-16  7:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-16  6:26 [PATCH] tap: Fix format specifier in tap4_is_fragment() warning Stefano Brivio
2023-08-16  6:58 ` David Gibson

Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).