From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id B17FE5A026F for ; Wed, 16 Aug 2023 09:08:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1692169703; bh=WMto7RaNbJfWnRbqewqcFvHxqesjZiz1q7ax9WmPoqA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AfJKryMClwKCa64q5hWtelUIlI0rgPoEwhfBxcYOXXgNMyXquZ8+K7QdONmIlvagU UIzml0LJCpx+CXJgWnI6wnomjwA6R27d2XPFwx4ELIbvUxTUWgISZFr+UkyaOQfIAs OwNY/2VU6+roAt0MT36hID75EKhlzeUWwne5GjRs= Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4RQfP314pQz4wxx; Wed, 16 Aug 2023 17:08:23 +1000 (AEST) Date: Wed, 16 Aug 2023 16:58:07 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] tap: Fix format specifier in tap4_is_fragment() warning Message-ID: References: <20230816062623.883685-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IDVWGHfapEdqYgrs" Content-Disposition: inline In-Reply-To: <20230816062623.883685-1-sbrivio@redhat.com> Message-ID-Hash: F5Z5QLR5HBEFMI5QZ3I4WBUP5EEI6PH3 X-Message-ID-Hash: F5Z5QLR5HBEFMI5QZ3I4WBUP5EEI6PH3 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --IDVWGHfapEdqYgrs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 16, 2023 at 08:26:23AM +0200, Stefano Brivio wrote: > Spotted by Coverity, relatively harmless. >=20 > Fixes: e01759e2fab0 ("tap: Explicitly drop IPv4 fragments, and give a war= ning") > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > tap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/tap.c b/tap.c > index a6f8692..760deb7 100644 > --- a/tap.c > +++ b/tap.c > @@ -561,7 +561,8 @@ static bool tap4_is_fragment(const struct iphdr *iph, > =20 > num_dropped++; > if (now->tv_sec - last_message > FRAGMENT_MSG_RATE) { > - warn("Can't process IPv4 fragments (%lu dropped)", num_dropped); > + warn("Can't process IPv4 fragments (%u dropped)", > + num_dropped); > last_message =3D now->tv_sec; > num_dropped =3D 0; > } --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --IDVWGHfapEdqYgrs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmTcc3gACgkQzQJF27ox 2GfVMw//TjETmgettV6guhUDCXa6eDEF9w0fU1SuUTvsW/6LSPoQDqopR0tg9T7B FXIDH63Gn/m9XFDyfw1j/Yt1/8Tq2AGzZF1fDehIhcKMh6zetBetoCWOreW/87Ys NlMXuq0QqPYZchmr+izwwwZ8uvxt9JD5Ru88DemSUE01fSq4eoGCscjuRfJf3cfq kUoThdUIW4Y3CnaifSXspCnFP2i5fDCZ7+YtNczuZNF3+ywb0FR0PtlRRPMpx+LI NDoNQGPrz8a4mdoKDrblYn4b6QU+LQ6pEtPnDISr3zbM5ltxE/DyHJsTmgWNGb+A 0phzFZxXg8YlbpMV8z2aaDAI+4ny/g4DQt8OOdSoJw1725pSdX+mcmk8iHqbB1ws RL4C48iYiUMY+rXJb8z+Nv0z2EFl4Cv+NfOyDtiJcPCRX3967HB4OKu6U4+CMHxX 86PXWx5xbDrC8e3lWepL5AI1WGhg8ugPn9PPMQ/fNcxmdL8sOOjaRarD7iFnEQ9Y xQIn99rtzx3W7IJFjst/gxc8XGbRVROdcE8OD8bFfhtm3141APIEw+CcWMsZiRgU 0zvmgeAQI+jEWPeMibdz6YqWzZvKv87pJoJImq22K+o8BH1T8oX0agREzEZt9i7t EjuGCfRMBc46cxtB/qCSagxPP4Xj7SdYKEXKfZXkMJxpOF30DDk= =yDdg -----END PGP SIGNATURE----- --IDVWGHfapEdqYgrs--