On Sat, Sep 23, 2023 at 12:06:06AM +0200, Stefano Brivio wrote:
> Note that tcp_sock_consume() doesn't update ACK sequence counters
> anymore.
> 
> Fixes: cc6d8286d104 ("tcp: Reset ACK_FROM_TAP_DUE flag only as needed, update timer")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  tcp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tcp.c b/tcp.c
> index dd3142d..aa1c8c9 100644
> --- a/tcp.c
> +++ b/tcp.c
> @@ -2103,7 +2103,7 @@ static void tcp_conn_from_tap(struct ctx *c,
>  }
>  
>  /**
> - * tcp_sock_consume() - Consume (discard) data from buffer, update ACK sequence
> + * tcp_sock_consume() - Consume (discard) data from buffer
>   * @conn:	Connection pointer
>   * @ack_seq:	ACK sequence, host order
>   *

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson