From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 1E45A5A026F for ; Sat, 23 Sep 2023 06:54:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1695444850; bh=4oWe4VnsKE8iinnGAYFptxTGOU6ECpBIQzda1H1vRnI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LH70sErhu2+oylx4AX2L3uPj+p4kmKH9HOJnqtsDbMEn+oNq+lYYr5BAUObCHD7ct FRpOLwSm92vsOVBH5T0ORRuMinMijQcSbsuV1LrKfL2FHvs8U3ryHrj6KWOP3L2MeN iJRqXZAe+k66tmLBNW1GfdheRhuFtGvYHeTWW/Yc= Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Rsxcf0Ys4z4x5F; Sat, 23 Sep 2023 14:54:10 +1000 (AEST) Date: Sat, 23 Sep 2023 12:48:39 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH RFT 1/5] tcp: Fix comment to tcp_sock_consume() Message-ID: References: <20230922220610.58767-1-sbrivio@redhat.com> <20230922220610.58767-2-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zzGCbDr6Oit7dvdF" Content-Disposition: inline In-Reply-To: <20230922220610.58767-2-sbrivio@redhat.com> Message-ID-Hash: U2KCGN4YPY773WXDKSDXHVBAOVFNXIJG X-Message-ID-Hash: U2KCGN4YPY773WXDKSDXHVBAOVFNXIJG X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Matej Hrica , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --zzGCbDr6Oit7dvdF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 23, 2023 at 12:06:06AM +0200, Stefano Brivio wrote: > Note that tcp_sock_consume() doesn't update ACK sequence counters > anymore. >=20 > Fixes: cc6d8286d104 ("tcp: Reset ACK_FROM_TAP_DUE flag only as needed, up= date timer") > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > tcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tcp.c b/tcp.c > index dd3142d..aa1c8c9 100644 > --- a/tcp.c > +++ b/tcp.c > @@ -2103,7 +2103,7 @@ static void tcp_conn_from_tap(struct ctx *c, > } > =20 > /** > - * tcp_sock_consume() - Consume (discard) data from buffer, update ACK s= equence > + * tcp_sock_consume() - Consume (discard) data from buffer > * @conn: Connection pointer > * @ack_seq: ACK sequence, host order > * --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --zzGCbDr6Oit7dvdF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmUOUe4ACgkQzQJF27ox 2GeTKw/+ORGEfIuyfCFfO/LQ8dx+MgXK5bRZeItPAlufzQrySflNp7ZF1ssSelW8 r0FWmIYNW7nbTTNZz2MCYC9tKJYUr2I7YID04Z9LVpc5qkubyMYr3Lp4zEs5FdWX r24UzzzffhVUrn4wRpQdQA41yuiMneX/FAuqzRu/+Yto5Z3kLusaikzK2qmMmm86 PqJKtlQsabiIMkugzrrF6TRB5asw5feMP6fH/ZEvTceTWo6DgVdEw4/AGyCopFr9 nt0ocn4SpVDdb/+4RKWCR6el8EkzyU4+jg1xqNXYWxTbLHemP1i4mEOphFjiw9Wn rDALOeuq2mLfCbrtZW513YrMET1hn8pj0TERFSIZaT5yTPNC6SRgRWaNU/0Z7OCh 6JovNfn80OIoYJLeT7GkObX6mfK7qGgj4cY4mdyAQ6eyODUSw7ehA4VMg+NMBStF st6QvqnR6Lbyakv5QXFodnN8hyypFLbrejyVGm5G+RKlRxODLyK+DBptj8tV6aCT pLahJP0Q78nXgbiI8s76A9sfWyzucTeNZgswehdcGd/i7bCCbh57x+N1ItMZQptU +eNHqbrCtosyMQBDscX2R/ZhQlRlayz+MBF+Ro0T6xisFlxW6i02z/6HY4SUG7+0 rHa+bSqzZYuOBEbycG4j3cAhtBoVdPR9DMF3J37Q50/K1VACBGM= =A08s -----END PGP SIGNATURE----- --zzGCbDr6Oit7dvdF--