From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id B0BA15A026F for ; Sat, 14 Oct 2023 02:44:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1697244263; bh=fG6FuHHfgWJU9VKM6ccP1KSWWaY7gpijQ+fCMcBJNGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ae9nRZL/8guNcCT/e5D6Oz1+g1Ux0Hi1FU6n7HX7vYLnq9JkzuwJN8RvIiug0ihmA WtArAMXMrlRR4dTV2pHIWzYVm01EXQQs95Y6STUk/vTLdcHIroU1fdzI8UP0Z2L76d 5rCRzHfnlkAOA6tEHK3ifAdzkrz0lbtPpL8sCDyE= Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4S6l4l1Q9fz4wd1; Sat, 14 Oct 2023 11:44:23 +1100 (AEDT) Date: Sat, 14 Oct 2023 11:44:17 +1100 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH] tcp: Remove remaining declaration of tcp_l2_mh Message-ID: References: <20231013084545.1968825-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0sHlfgVNPA2pVgCO" Content-Disposition: inline In-Reply-To: <20231013084545.1968825-1-lvivier@redhat.com> Message-ID-Hash: GWTK3X2NS645A6NJH3ED7KK34XL3N5QE X-Message-ID-Hash: GWTK3X2NS645A6NJH3ED7KK34XL3N5QE X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --0sHlfgVNPA2pVgCO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 13, 2023 at 10:45:45AM +0200, Laurent Vivier wrote: > Use of tcp_l2_mh has been removed in commit 38fbfdbcb95d, > but its declaration and initialization are always in the code. > Remove them as they are useless. >=20 > Fixes: 38fbfdbcb95d ("tcp: Get rid of iov with cached MSS, drop sendmmsg(= ), add deferred flush") > Cc: sbrivio@redhat.com > Signed-off-by: Laurent Vivier Acked-by: David Gibson > --- > tcp.c | 6 ------ > 1 file changed, 6 deletions(-) >=20 > diff --git a/tcp.c b/tcp.c > index 945023c5b442..386cd015be1c 100644 > --- a/tcp.c > +++ b/tcp.c > @@ -515,8 +515,6 @@ static struct iovec tcp6_l2_iov [TCP_FRAMES_MEM]; > static struct iovec tcp4_l2_flags_iov [TCP_FRAMES_MEM]; > static struct iovec tcp6_l2_flags_iov [TCP_FRAMES_MEM]; > =20 > -static struct mmsghdr tcp_l2_mh [TCP_FRAMES_MEM]; > - > /* sendmsg() to socket */ > static struct iovec tcp_iov [UIO_MAXIOV]; > =20 > @@ -3143,7 +3141,6 @@ static void tcp_sock_refill_init(const struct ctx *= c) > */ > int tcp_init(struct ctx *c) > { > - int i; > #ifndef HAS_GETRANDOM > int dev_random =3D open("/dev/random", O_RDONLY); > unsigned int random_read =3D 0; > @@ -3172,9 +3169,6 @@ int tcp_init(struct ctx *c) > exit(EXIT_FAILURE); > } > =20 > - for (i =3D 0; i < ARRAY_SIZE(tcp_l2_mh); i++) > - tcp_l2_mh[i] =3D (struct mmsghdr) { .msg_hdr.msg_iovlen =3D 1 }; > - > if (c->ifi4) > tcp_sock4_iov_init(c); > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --0sHlfgVNPA2pVgCO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmUp5FoACgkQzQJF27ox 2GcDMA//bLe9hgS3zQRgytWGwaSFFdkBeuWSW0VGZTbnjBcqqt2tVclm9nmR30sE 2KFxZ0QrenLxh8Z8saSeWKm/vSOVNSuch4R1AOoqKARxihcjYYmOvv2uyVBJNgUI Bv5NTXfJFA/Gh++3Z6KOTI/yIHaqoRcrLf/pTCIHAtpCT7daZLUQymcvt94UtEzu NTxdCPIL77zxCknoPfH/Wpq9ewlCVCD0ytlOFS7f9CgvTc+mBXC+/Dt7Y8sWm231 pJSXJi/1tuNrmOG+yODlvYFtb+cfJD9w6LFL19d0Wqi26/jrzM9cPARSO7Ve8w6C 6zNSpOzT349Yslzw3AW4+BW1yWGb1ovIg3viAwMyroc7JgYhp2LRNJXiBSZNv/L4 MWWU6SFFqJge8nzv374db+xm/o3RbzoNBZkbwxiKeSIVaL/7AQSfo3n8K0UroVEN w4QJ02v2pqIWhmTKGubK1NSC9J46bVOtRfrCz9yE0e5opfqthNrhPO6mxpySRd+R zigWK98EhN2kJ4pD1/6+Xh5OuM5NhNZCe5ncvK1UCV7C1k2SJYsA1QXHi/wL+bOy YdjlSJNN+xFKNMwssAP5+75oWCGNHsG/7ez2RoLIn/9erc354ufoXbRYDcKvylBB ZvfHDDuMlgMrn5T56jP/fz6S9cmTLJ4YyPYAZ9HMqRhGCojiPnU= =MCDw -----END PGP SIGNATURE----- --0sHlfgVNPA2pVgCO--