From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id DB81E5A026F for ; Thu, 23 Nov 2023 05:47:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1700714821; bh=AB74K59tUZ1J0IM5iCKevlhNOBwQFt5twskWlGWqUJk=; h=Date:From:To:Subject:References:In-Reply-To:From; b=MsdSHyv09ryvfu3dqbPh2DiZP8zXmPZsU6+4/LgamOlxuF6OkCn3BC6UUVAQzRctr PqrW5/rNzuxsYBLbH7ZfO3ulzicGAvohRdZoEQriwaqsn2xx8YjXmvUwE2kUnROl7D p9s+JsxyfBW+9XzqgWi2ytzY+V1oQTDVr/NMVw9U= Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4SbQZF0tyXz4xR5; Thu, 23 Nov 2023 15:47:01 +1100 (AEDT) Date: Thu, 23 Nov 2023 15:46:56 +1100 From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: Re: [PATCH 0/6] Introduce unified flow table, first steps Message-ID: References: <20231123023629.2024938-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AaMIQvPW14kKoxHp" Content-Disposition: inline In-Reply-To: <20231123023629.2024938-1-david@gibson.dropbear.id.au> Message-ID-Hash: WSPXBWTTK7QDFZNOIGVX6ZH67QEAC7IL X-Message-ID-Hash: WSPXBWTTK7QDFZNOIGVX6ZH67QEAC7IL X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --AaMIQvPW14kKoxHp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 23, 2023 at 01:36:23PM +1100, David Gibson wrote: > Here's my latest revision of some of the basics of the flow table. So > far it's basically just a renaming of the existing TCP connection > table. It's used for some new logging helpers, but otherwise doesn't > really function any differently. >=20 > However, this subset of the flow table work no longer bloats > flow/connection entries over a single cache line. That removes the > most prominent drawback of earlier revisions, meaning I think this > series is ready for merge now. Doing so will mean the later series > making more substantive changes to the flow behaviour are simpler. Since posting this, I've come up with some small revisions. So, please don't apply as is. I'll respin once you review incorporating both your feedback and the changes I already made. >=20 > David Gibson (6): > test: Make handling of shell prompts with escapes a little more > reliable > flow, tcp: Generalise connection types > flow, tcp: Move TCP connection table to unified flow table > flow, tcp: Consolidate flow pointer<->index helpers > flow: Make unified version of flow table compaction > flow, tcp: Add logging helpers for connection related messages >=20 > Makefile | 14 +-- > flow.c | 87 +++++++++++++++++++ > flow.h | 60 +++++++++++++ > flow_table.h | 45 ++++++++++ > passt.h | 3 + > tcp.c | 232 +++++++++++++++++++++++--------------------------- > tcp.h | 5 -- > tcp_conn.h | 46 +++------- > tcp_splice.c | 88 +++++++++---------- > test/lib/term | 6 +- > 10 files changed, 361 insertions(+), 225 deletions(-) > create mode 100644 flow.c > create mode 100644 flow.h > create mode 100644 flow_table.h >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --AaMIQvPW14kKoxHp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmVe2T8ACgkQzQJF27ox 2Ge2/A//Sypkm1zDVDxbLM0uKhvfWgJzQl1uGAvVkU+IGYZeTE4WIQMHVzhln0EJ G3vsXrGI78IHyCHhNoRzH+j1EQNcDDPY9SEY+sIkv8amXFIBSD4Bl6KZkj517axm hfdXFVjCkfPncW9muCCKfBYc2VVkUXQF4FlNPEGhl5kCf0nQhG+n9oPl/VVmSH5A uh7WqcCHAd+gppd1Jyvyc5L8ms2Z5xY0njVkb0koCm6r4KccTeQjX1DZZFe0J5KO ZXq6zNKCajNVkEdJSF4ozThT2cyPtB2hcmlXXLBCn3rgafwHQyvygw08oVkvHtzn 4wzkCrgzEdwRuBDI4MnGoeg4Z9VUXmeq+ql11qAtbgeLL0Z2DJg2HrYBU4zIK9sY Bm+gnjziLMhKLQm8kn3w8QQPfk+KELMTXQHwTN8JjNfAUqWQEqYFkuNKOpGZXAR9 DcJipo8gUVdRGht09VLl4VjGLDEOdd8t2DSMY0SRG9RRpmBQf3QXYbxafy6PIh8b u9w2R1wmmf8CJ9vM91U0Epr+4iQNrcNdEmOvaKgT6G/rqkOODj5bFO3mmXfqyjOR GeIhNwT7cFgZtuobx1ZPBw9TxQEtU8BKuAGZCLwNtKrPglpxqgyVr9XOHwui+wGU Q/sTasZhV27f7NruKbQqLYgnECR+j3UAUkEH77WWZN0M/6EicSs= =7KC/ -----END PGP SIGNATURE----- --AaMIQvPW14kKoxHp--