From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id D52A85A027C for ; Thu, 30 Nov 2023 01:55:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1701305703; bh=nOlsQzqdHOpvIhZ+Y43KQ2loeqgoDqsBQrOc5OOSluQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nScs1jnIfR1kjAlVrFb6gaRMjOwa2YaZETUyTE8Dx303L8Jel3GziEtgsC+Nx2fF2 qkErJyvwczbYCzb6XgJ/EZdNTVuSJ1XTyPO0P5mtsm2NkQSfatJLJqpMhGfy17Ox/p v7kPLTxEF9CE0siSHOg2f9MaGBBluq3oZVBkcNOo= Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Sgd5M3JXwz4xW6; Thu, 30 Nov 2023 11:55:03 +1100 (AEDT) Date: Thu, 30 Nov 2023 11:15:47 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 1/4] treewide: Use 'z' length modifier for size_t/ssize_t conversions Message-ID: References: <20231129134610.3796809-1-sbrivio@redhat.com> <20231129134610.3796809-2-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UgVHcWM+hvNZ0qab" Content-Disposition: inline In-Reply-To: <20231129134610.3796809-2-sbrivio@redhat.com> Message-ID-Hash: ZYL3WO6HGSJEOWK4NTLM3AMYDPWGXDID X-Message-ID-Hash: ZYL3WO6HGSJEOWK4NTLM3AMYDPWGXDID X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, lemmi@nerd2nerd.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --UgVHcWM+hvNZ0qab Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 29, 2023 at 02:46:07PM +0100, Stefano Brivio wrote: > Types size_t and ssize_t are not necessarily long, it depends on the > architecture. Most LGTM, but a couple of nits: [snip] > @@ -106,7 +106,7 @@ void *packet_get_do(const struct pool *p, size_t idx,= size_t offset, > =20 > if (p->pkt[idx].offset + len + offset > p->buf_size) { > if (func) { > - trace("packet offset plus length %lu from size %lu, " > + trace("packet offset plus length %lu from size %zu, " The change here is certainly correct. But the remaining %lu is dubious. The value given is the sum of a uint32_t and two size_t, so it could depend on platform what exactly that will be promoted to. I think we should probably either cast the result explicitly to (size_t) and use %zu, or cast to (uint32_t) and use "%" PRIu32. [snip] > diff --git a/tcp_splice.c b/tcp_splice.c > index a5c1332..8d08bb4 100644 > --- a/tcp_splice.c > +++ b/tcp_splice.c > @@ -321,7 +321,7 @@ static int tcp_splice_connect_finish(const struct ctx= *c, > =20 > if (fcntl(conn->pipe[side][0], F_SETPIPE_SZ, > c->tcp.pipe_size)) { > - trace("TCP (spliced): cannot set %d->%d pipe size to %lu", > + trace("TCP (spliced): cannot set %d->%d pipe size to %zu", > side, !side, c->tcp.pipe_size); > } > } > @@ -554,7 +554,7 @@ retry: > readlen =3D splice(conn->s[fromside], NULL, > conn->pipe[fromside][1], NULL, c->tcp.pipe_size, > SPLICE_F_MOVE | SPLICE_F_NONBLOCK); > - trace("TCP (spliced): %li from read-side call", readlen); > + trace("TCP (spliced): %zi from read-side call", readlen); > if (readlen < 0) { > if (errno =3D=3D EINTR) > goto retry; > @@ -580,7 +580,7 @@ eintr: > written =3D splice(conn->pipe[fromside][0], NULL, > conn->s[!fromside], NULL, to_write, > SPLICE_F_MOVE | more | SPLICE_F_NONBLOCK); > - trace("TCP (spliced): %li from write-side call (passed %lu)", > + trace("TCP (spliced): %zi from write-side call (passed %zu)", > written, to_write); 'to_write' is actually an ssize_t which would suggest %zi. However looking at the code, I think to_write probably *should* be a size_t instead. > =20 > /* Most common case: skip updating counters. */ > @@ -718,7 +718,7 @@ static void tcp_splice_pipe_refill(const struct ctx *= c) > =20 > if (fcntl(splice_pipe_pool[i][0], F_SETPIPE_SZ, > c->tcp.pipe_size)) { > - trace("TCP (spliced): cannot set pool pipe size to %lu", > + trace("TCP (spliced): cannot set pool pipe size to %zu", > c->tcp.pipe_size); > } > } --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --UgVHcWM+hvNZ0qab Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmVn1CAACgkQzQJF27ox 2GdF/A//eCKXpe5j0Le+kSjnQO/XruXI//jDWx6N9TKeijMIdyUGFLj86PYnoe9A TJBAc4HR4ntNUJLgOgQZXGd3c9bdmQxy83vEzmADx/ZwiPOxwUu6xo4FgUtwD0MR qRJGmC+LshPMiYNdI/WMCkxOCqulMm2rZACiQbrgTNj5KqkOA1Y5xz6bBzx0UQ7X flB2gmlr97Vt/7MfsNfZXSCX3qtHRqTdKCITOS61yfGwMPQHhgNWfTkJBnyt2DA+ vXD0dmLjVI5AvSrVUNBwyrq45MWajJTVJUWVR7UyK20Hiye/wcSy7Xqdti0S1hSq VxOdIYwoxDaNnVwm060OCJ+TTjQ7bEOu+MYE5UUCaj9B6MHc5/E0EEyk4hYxvqWk PtYFqdo3zn62jzktKj721aFAe3xUYhFsKVghCBkQiEvnni6+vLB2f+HA3PhTv6tA R+x04MfqM+teNOsdU2yDdliln/8Q5IL+0Ys8/lMFUGp4XRBMZEsaJ5/mgXhx//GF 1ISm/DgzghYGCTF8dRNP2Y4e/C3/mpza9gWWKr+DaMRKuLDRLPZVtHQjVN+iWkus Vtj9XSIm7oNHEoBGQ1Yb16xKqC/Zdrp2TaH9jzjv945xQ5uGjzz56MwCcP57Pyxg Ssf9LfxZYxCttnZz+nkodvAVwUb5OfwsZQOh9ew/13iYDo6g0J8= =ZPLj -----END PGP SIGNATURE----- --UgVHcWM+hvNZ0qab--