From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] netlink: nl_addr_get() returns 0, not 9, on success
Date: Thu, 28 Dec 2023 13:47:51 +1100 [thread overview]
Message-ID: <ZYzh19O1iNesZ3wP@zatzit> (raw)
In-Reply-To: <20231227155330.2485096-1-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
On Wed, Dec 27, 2023 at 04:53:30PM +0100, Stefano Brivio wrote:
> Fixes: 5103811e2df3 ("netlink: Propagate errors for "dump" operations")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink.c b/netlink.c
> index 379d46e..b221c79 100644
> --- a/netlink.c
> +++ b/netlink.c
> @@ -535,7 +535,7 @@ int nl_route_dup(int s_src, unsigned int ifi_src,
> * @prefix_len: Mask or prefix length, to fill (for IPv4)
> * @addr_l: Link-scoped address to fill (for IPv6)
> *
> - * Return: 9 on success, negative error code on failure
> + * Return: 0 on success, negative error code on failure
> */
> int nl_addr_get(int s, unsigned int ifi, sa_family_t af,
> void *addr, int *prefix_len, void *addr_l)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-12-28 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 15:53 [PATCH] netlink: nl_addr_get() returns 0, not 9, on success Stefano Brivio
2023-12-28 2:47 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYzh19O1iNesZ3wP@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).