From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id A15925A0272 for ; Thu, 28 Dec 2023 06:58:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1703743124; bh=fuo+4jQCs6EEMUavwyyXfvxHBjYHZmy+Hf2iFVZ+0tM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dded6Z7YeV5qDt8n7tayqWcdChnn3Hu0HCRiYbpA9scMwW7chDYDVJZfqc0dlb5RG Q6m30HUVSorLIkgTzNPsYIsK76wtD181B2N+qpVLayOC/IjtT6r64fxPlcNyMp//dO ZfTAx1nhWJb71z0xzersbbzG4en+3jA+ZNcVAGlezAWZJ2ZgtJFYWtCWmYQYoFyvzW q1ExnHGfq/XwmsnyVSq31dUczKtmRUi9/PRnCKYPleQeZRwx/Iy43gXhgZ2aVBQfG4 TCFU/P75lleKX+R0cCZyJ1JuOHJebgivUw3Azb5g1S2r4YzVELdn2Ns9TP8x7i2wPQ dm2S4n8AiESTA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4T0yVr1yKZz4wc8; Thu, 28 Dec 2023 16:58:44 +1100 (AEDT) Date: Thu, 28 Dec 2023 13:47:51 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] netlink: nl_addr_get() returns 0, not 9, on success Message-ID: References: <20231227155330.2485096-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gPejHXxrZrPiVhfI" Content-Disposition: inline In-Reply-To: <20231227155330.2485096-1-sbrivio@redhat.com> Message-ID-Hash: DB3VJMS6AMBJ53QEIJTRCU6ESVHGEXYP X-Message-ID-Hash: DB3VJMS6AMBJ53QEIJTRCU6ESVHGEXYP X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --gPejHXxrZrPiVhfI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 27, 2023 at 04:53:30PM +0100, Stefano Brivio wrote: > Fixes: 5103811e2df3 ("netlink: Propagate errors for "dump" operations") > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > netlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/netlink.c b/netlink.c > index 379d46e..b221c79 100644 > --- a/netlink.c > +++ b/netlink.c > @@ -535,7 +535,7 @@ int nl_route_dup(int s_src, unsigned int ifi_src, > * @prefix_len: Mask or prefix length, to fill (for IPv4) > * @addr_l: Link-scoped address to fill (for IPv6) > * > - * Return: 9 on success, negative error code on failure > + * Return: 0 on success, negative error code on failure > */ > int nl_addr_get(int s, unsigned int ifi, sa_family_t af, > void *addr, int *prefix_len, void *addr_l) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --gPejHXxrZrPiVhfI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmWM4csACgkQzQJF27ox 2GeCtw/+Is25/O3jAcAh7hxVWk/gaPgMBOeW4xa09m60PwBX1muBJv2cMr0fu+7j FCjLcnqhUNpxxo5UBPM6FrSI70FSLVvVeHZLVj3EPysqOpCTv09FZn6wx8YMpr3P PTgMgpaxHti5DosfCVmByL1vt5JtcZI8ROqG20ie/QDLjLPDKKcgor5Jip8CriPS Krj1ZEFwPyyxJ1Anql0iNVl7Qw3JY2rEoiCMEp7zT7Bg1baoqJaUaJIWAqLJE+SJ fsxuW1A6SCZBUYGmNYE7ldVJyZ3uwNqNtLdchrqXLPMEugSjAJqSoUtj+/UccAs1 qEQoaQp6vCUlvFm1EafLBQerU3G4eGMbAzLl3E7p1SvX881CyUj94+WHPioLbUBe 4BHwCiAi8Rtthw2opz9tcnfGbbETzubIRJQLSd3Jx/UedhM1GBlC8AswDZScP0OB BtRB5Onx+LjR4GYFmW95JMT60wsLE5ebpPVLX1f2vOdycHA3VGt0/bTdBFTn+2/M N9FRL1zgEIUZ1kHQkLBcuNXoyJQLX8IwaBkS7DSRL1L0JtDjz/DeEYrbUOnfmfax mWskMIpRm56tothgziZ+VDOqxZF8AVFXX6lsonOJLfwQ6Ot7+zvSstHIQBvZfoxk NUGbfaXPOqwvkYgV75NrOfj/ce++NJ7D43jxLd7fZmpnV+ImLws= =dFGy -----END PGP SIGNATURE----- --gPejHXxrZrPiVhfI--