* [PATCH] netlink: nl_addr_get() returns 0, not 9, on success
@ 2023-12-27 15:53 Stefano Brivio
2023-12-28 2:47 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Stefano Brivio @ 2023-12-27 15:53 UTC (permalink / raw)
To: passt-dev; +Cc: David Gibson
Fixes: 5103811e2df3 ("netlink: Propagate errors for "dump" operations")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/netlink.c b/netlink.c
index 379d46e..b221c79 100644
--- a/netlink.c
+++ b/netlink.c
@@ -535,7 +535,7 @@ int nl_route_dup(int s_src, unsigned int ifi_src,
* @prefix_len: Mask or prefix length, to fill (for IPv4)
* @addr_l: Link-scoped address to fill (for IPv6)
*
- * Return: 9 on success, negative error code on failure
+ * Return: 0 on success, negative error code on failure
*/
int nl_addr_get(int s, unsigned int ifi, sa_family_t af,
void *addr, int *prefix_len, void *addr_l)
--
@@ -535,7 +535,7 @@ int nl_route_dup(int s_src, unsigned int ifi_src,
* @prefix_len: Mask or prefix length, to fill (for IPv4)
* @addr_l: Link-scoped address to fill (for IPv6)
*
- * Return: 9 on success, negative error code on failure
+ * Return: 0 on success, negative error code on failure
*/
int nl_addr_get(int s, unsigned int ifi, sa_family_t af,
void *addr, int *prefix_len, void *addr_l)
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] netlink: nl_addr_get() returns 0, not 9, on success
2023-12-27 15:53 [PATCH] netlink: nl_addr_get() returns 0, not 9, on success Stefano Brivio
@ 2023-12-28 2:47 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2023-12-28 2:47 UTC (permalink / raw)
To: Stefano Brivio; +Cc: passt-dev
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
On Wed, Dec 27, 2023 at 04:53:30PM +0100, Stefano Brivio wrote:
> Fixes: 5103811e2df3 ("netlink: Propagate errors for "dump" operations")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink.c b/netlink.c
> index 379d46e..b221c79 100644
> --- a/netlink.c
> +++ b/netlink.c
> @@ -535,7 +535,7 @@ int nl_route_dup(int s_src, unsigned int ifi_src,
> * @prefix_len: Mask or prefix length, to fill (for IPv4)
> * @addr_l: Link-scoped address to fill (for IPv6)
> *
> - * Return: 9 on success, negative error code on failure
> + * Return: 0 on success, negative error code on failure
> */
> int nl_addr_get(int s, unsigned int ifi, sa_family_t af,
> void *addr, int *prefix_len, void *addr_l)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-28 5:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-27 15:53 [PATCH] netlink: nl_addr_get() returns 0, not 9, on success Stefano Brivio
2023-12-28 2:47 ` David Gibson
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).