From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202504 header.b=T02l3SDl; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id A23A65A0272 for ; Wed, 16 Apr 2025 07:55:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202504; t=1744782922; bh=demJkR/xH0mrRm5WA1CNpIgg5bAFS0W0ybetotZJ6kA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T02l3SDl7/pBXXczK3MUlrG48X8bX6vouSXFao0A8KXx5VIKQmCNW7nFPbpDPkqeS UNdms5A9HuQqdf7seMM/cmB4xt9ndwfqH77RGng7lEJvh4SETgf1dG63sSWbKyqrzK JgNpmQw/x9paQx2OZdmDch9JYf11sbR6BIo4Dg0ribgu2Rz5wSyrwJsaH2T1DAfpZK chr4H0+4anranfJhypcyhVHxJAq1zTdbKgbXl+WxpB3HPN6PbuV3aEWm33IiCrrgoz fTTLx0ZQ4BfNNWlPbFzx5kkRE4Q3nQQJVCSpjVmlSdm7qnigKCYHH/bdWCokkdMz0/ qjGXvwFuZ5RmQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Zcqxk39qbz4xQQ; Wed, 16 Apr 2025 15:55:22 +1000 (AEST) Date: Wed, 16 Apr 2025 13:06:12 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v3 06/20] packet: Add packet_data() Message-ID: References: <20250415094300.65794-1-lvivier@redhat.com> <20250415094300.65794-7-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kabbUacy9d1zFuQY" Content-Disposition: inline In-Reply-To: <20250415094300.65794-7-lvivier@redhat.com> Message-ID-Hash: S6IDH2BRJ3BBLBFAFDAK4VSKA3MBHTWW X-Message-ID-Hash: S6IDH2BRJ3BBLBFAFDAK4VSKA3MBHTWW X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --kabbUacy9d1zFuQY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 15, 2025 at 11:42:46AM +0200, Laurent Vivier wrote: > packet_data() gets the data range from a packet descriptor from a > given pool. >=20 > It uses iov_tail to return the packet memory. >=20 > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > packet.c | 41 +++++++++++++++++++++++++++++++++++++++++ > packet.h | 5 +++++ > 2 files changed, 46 insertions(+) >=20 > diff --git a/packet.c b/packet.c > index 98ded4e27aae..675bccf4d787 100644 > --- a/packet.c > +++ b/packet.c > @@ -190,6 +190,47 @@ void *packet_get_do(const struct pool *p, const size= _t idx, > return r; > } > =20 > +/** > + * packet_data_do() - Get data range from packet descriptor from given p= ool > + * @p: Packet pool > + * @idx: Index of packet descriptor in pool > + * @data: IOV tail to store the address of the data (output) > + * @func: For tracing: name of calling function, NULL means no trace() > + * @line: For tracing: caller line of function call > + * > + * Return: true if @data contains valid data, false otherwise > + */ > +/* cppcheck-suppress unusedFunction */ > +bool packet_data_do(const struct pool *p, size_t idx, > + struct iov_tail *data, > + const char *func, int line) > +{ > + size_t i; > + > + ASSERT_WITH_MSG(p->count <=3D p->size, > + "Corrupt pool count: %zu, size: %zu, %s:%i", > + p->count, p->size, func, line); > + > + if (idx >=3D p->count) { > + debug("packet %zu from pool size: %zu, count: %zu, " > + "%s:%i", idx, p->size, p->count, func, line); > + return false; > + } > + > + data->cnt =3D 1; > + data->off =3D 0; > + data->iov =3D &p->pkt[idx]; > + > + for (i =3D 0; i < data->cnt; i++) { > + ASSERT_WITH_MSG(!packet_check_range(p, data->iov[i].iov_base, > + data->iov[i].iov_len, > + func, line), > + "Corrupt packet pool, %s:%i", func, line); > + } > + > + return true; > +} > + > /** > * pool_flush() - Flush a packet pool > * @p: Pointer to packet pool > diff --git a/packet.h b/packet.h > index af40b39b5251..062afb978124 100644 > --- a/packet.h > +++ b/packet.h > @@ -39,6 +39,9 @@ void *packet_get_try_do(const struct pool *p, const siz= e_t idx, > void *packet_get_do(const struct pool *p, const size_t idx, > size_t offset, size_t len, size_t *left, > const char *func, int line); > +bool packet_data_do(const struct pool *p, const size_t idx, > + struct iov_tail *data, > + const char *func, int line); > bool pool_full(const struct pool *p); > void pool_flush(struct pool *p); > =20 > @@ -49,6 +52,8 @@ void pool_flush(struct pool *p); > packet_get_try_do(p, idx, offset, len, left, __func__, __LINE__) > #define packet_get(p, idx, offset, len, left) \ > packet_get_do(p, idx, offset, len, left, __func__, __LINE__) > +#define packet_data(p, idx, data) \ > + packet_data_do(p, idx, data, __func__, __LINE__) > =20 > #define PACKET_POOL_DECL(_name, _size, _buf) \ > struct _name ## _t { \ --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --kabbUacy9d1zFuQY Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmf/HqMACgkQzQJF27ox 2GfjcQ//ebkLtMyMOgBDej3zRnXxHR6SbCfqNzaxZHVH9ucNodTQ22VLqI7KuJdx fhw4LDhdzUcHlxKYLLPD2reGzFumixqJq6UalTiDf8g3Yug3HS9cCsxkG/Xl44Yp ph5VCqIBk81Z4fSn9pNFjsNoX7yjHh3HJfosGpqppndybXnBR8fufWVES0rPQn7m h+VqVe/QQZGH/K9V/TCC8op9qKO1GD7jnV/8s3mLR1v0MX5IkDHe9vtkxWR5Tn+v 3O2a7eggx6efSX7R2nWgUYIt3WF+FLZ6yb66LuRoYyALw8SdQWFuXbRua7wqx2E2 uxyLkZwMgHqGLWPTUu+fpyhlz/KlnSQi6/cG8cKrpeLmyFokMQ29BocNfz694pk8 BHUV7jcvSNfpMNBlCwWuAtPJfFBNuy8pFopNYeZZNS04nGJ87K6iWJfHkakyWRy2 LgZX/k16FFnMzrcOXM3FzOofIbmcPngha3beypc1XJ11QxZNPZo8BMD5jizM/SNc 8bgq08JWdKTb74sNoxIC8SSMLdTiJVTKBC9cjki7SiXbcztvEBU0VbvPSMQSHUdM V5KEFzTYJWkAbc/wSbekr5lbrIqYlALK63zQ8mdwB1/URW4namGjQIKdA2N/oktS JjLAyF89inkVMIfe+EMMiWARsWJ+fgW32zfarg0geLJNwGHeMcs= =q1/e -----END PGP SIGNATURE----- --kabbUacy9d1zFuQY--