From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 0C4C35A027F for ; Fri, 16 Feb 2024 03:49:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1708051749; bh=BA+ImRQonJF1ERDyqx26mx52TH47xTy+2faHEjU6nrk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E9w5Ak2dX+TY9X+UP3k6DdAKX72T/lscak3/JPbE7YRoBPiqc8KGhFkIS5IbjbipO GZRScRDOw7FKEj3hKe7qsfDIZUuTESU0mujnyJkN3bAv1zAyKNnl+cOAlJrHU7AnMX idbZRM8fmuiBbdS474WmBalPxdvftGD+vthIhahyCir+DTxazV8TXtIB7ocstKqU4s wuO2/IN1i+as+/sNyqb2GfvIYEwa9SdoNgjJhR/v4x2hQNlL9x1rc1+6zMMQ4iuQg4 SeCAFDxjMV8oVS1TWdn0SKeJbaHj/Til+wlaHOW8xXgx1X+r554DMxszwk41X1akRN 1UubihD4Uagig== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Tbbx10NHcz4wyy; Fri, 16 Feb 2024 13:49:09 +1100 (AEDT) Date: Fri, 16 Feb 2024 13:49:01 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] conf: No routable interface for IPv4 or IPv6 is informational, not a warning Message-ID: References: <20240215225059.491656-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hSJDB5QqeflBORoo" Content-Disposition: inline In-Reply-To: <20240215225059.491656-1-sbrivio@redhat.com> Message-ID-Hash: NCDPASXMSJPUI5DEP6UL7QLHI5HEVN7C X-Message-ID-Hash: NCDPASXMSJPUI5DEP6UL7QLHI5HEVN7C X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --hSJDB5QqeflBORoo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 15, 2024 at 11:50:59PM +0100, Stefano Brivio wrote: > ...Podman users might get confused by the fact that if we can't > find a default route for a given IP version, we'll report that as a > warning message and possibly just before actual error messages. >=20 > However, a lack of routable interface for IPv4 or IPv6 can be a > normal circumstance: don't warn about it, just state that as > informational message, if those are displayed (they're not in > non-error paths in Podman, for example). >=20 > Reported-by: Paul Holzinger > Link: https://github.com/containers/podman/pull/21563#issuecomment-193702= 4642 > Signed-off-by: Stefano Brivio I have mixed feelings about this. On the one hand it's certainly true that these messages don't necessarily indicate a problem. Also that we've had people think they were the undelying cause of later hard errors, when in fact they were unrelated. On the other hand, these messages do indicate that we're entirely disabling either IPv4 or IPv6 connectivity. The fact that this relies on having external routability is itself non-obvious (and is something we want to remove, but it will take a while). As an info message, I can see people being confused instead that "why is no IPv[46] working?" despite no errors or warnings. So... maybe reduce to info level, but make the text clearer that we're disabling the relevant IP version? > --- > conf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/conf.c b/conf.c > index 5e15b66..2341007 100644 > --- a/conf.c > +++ b/conf.c > @@ -579,7 +579,7 @@ static unsigned int conf_ip4(unsigned int ifi, > ifi =3D nl_get_ext_if(nl_sock, AF_INET); > =20 > if (!ifi) { > - warn("No external routable interface for IPv4"); > + info("No external routable interface for IPv4"); > return 0; > } > =20 > @@ -651,7 +651,7 @@ static unsigned int conf_ip6(unsigned int ifi, > ifi =3D nl_get_ext_if(nl_sock, AF_INET6); > =20 > if (!ifi) { > - warn("No external routable interface for IPv6"); > + info("No external routable interface for IPv6"); > return 0; > } > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --hSJDB5QqeflBORoo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmXOzQ0ACgkQzQJF27ox 2Gd8NBAAj5m4HbhUldI8fsG6v6Dd7GG1fnl5SRBh24aUqYm6M0yyDtjWXBxFPOxo +a97bljRRSAQUdbhE0CehjNzr5xoTxZxPz3eoEzqCcG9r56NrytbxHDN0M2KCLdE bFrmEAD0KBKzJQuN5TXZcipSRWgtn/oswF0dKBkHDyj+VYklQJKn+hElE6RLrqec jrtBTyfLJde8so2dF5NEZedZ6Im/8Ei9ft4RDUx9O9NzNCswRFwkWw4fpY38CXLv DSxxcHMpoZKzrSzV08q/42Z9INcPgK45I3n4FLFzi0ahsVbxLyJXwhdy2yvd1QfK ze2hchB8DDCACqNl07qsFTS7jZjvZ7VMwASGkJI70D8zpMb5bjtIdT0W6BVTgb5H iSSdtUBai64dy2CroyIk2Gq/Yi828W1FjFP6JSk7CKo2rF2QESGt4SjyjxQx3VwA uZLsCT70yCkbUK58dp6F6V+/ZxQBbB5W4i39GqhTi/eugBHysa4guhZZ+NjnJyMf rr0ZZ8nYtRDEDiVYehhqHwk/98vXSEn2qrZCjPe1Oui0YwmNR2uZcHF41Xiam9sH yhWkDIQiB5ULtVD3+sL5qSvjkZR/mSMzcCrAYc9h9NMDA2q/T4bVHqHbVthN173M e7qRkP+EYJQOLPEWwGk+2h0/njsgGkWGe9/mzQrWbvlLc4vacuE= =SFxc -----END PGP SIGNATURE----- --hSJDB5QqeflBORoo--