From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 5DB3E5A0272 for ; Tue, 6 Feb 2024 03:14:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1707185686; bh=ImuNTM5U4Ft8CtNelX1kmT7J5bClzbrKONsH+ZtsxkM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z4VHVCg2LfervWov+NEwGBIJHuNvEmOY3qqFuPs1OsjwXjQ8H9NvSR0HISlglWgUz v+HrkzyPoCO3U9kuHwJog0RdIs6ImDcJJdTQp5OpJwOzx0YLm0Uc1xDVUeEsTNuEvx 7uRBispJpiIacXDZybXhrA5YguBUllhPP5YhoCjqIjq5zwBBr6+GV4g2hQKixfritH BkpMQ3T5XoSVEkcMh7xNdvSDMvxeOEiXBqSRRdaGXOCTpzDiD8SV2wSmRU8SfigReq /AyVDBtvvUOKMY0lLtt+0fyv7MjURVyGk6C2sWxAAG/an0taCuP5qd0g2wxZu0wG3f B4avOtHcQ9+8g== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4TTRdy05rwz4wp3; Tue, 6 Feb 2024 13:14:46 +1100 (AEDT) Date: Tue, 6 Feb 2024 13:14:41 +1100 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH 15/24] udp: rename udp_sock_handler() to udp_buf_sock_handler() Message-ID: References: <20240202141151.3762941-1-lvivier@redhat.com> <20240202141151.3762941-16-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3IM531mIHR+Nvth0" Content-Disposition: inline In-Reply-To: <20240202141151.3762941-16-lvivier@redhat.com> Message-ID-Hash: HMXT3QKUNDRPGN3QDZDW4GKPYHDEKVIZ X-Message-ID-Hash: HMXT3QKUNDRPGN3QDZDW4GKPYHDEKVIZ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --3IM531mIHR+Nvth0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 02, 2024 at 03:11:42PM +0100, Laurent Vivier wrote: > We are going to introduce a variant of the function to use > vhost-user buffers rather than passt internal buffers. Not entirely sure the new name really conveys that distinction. >=20 > Signed-off-by: Laurent Vivier > --- > passt.c | 2 +- > udp.c | 6 +++--- > udp.h | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/passt.c b/passt.c > index 10042a9b9789..c70caf464e61 100644 > --- a/passt.c > +++ b/passt.c > @@ -389,7 +389,7 @@ loop: > tcp_timer_handler(&c, ref); > break; > case EPOLL_TYPE_UDP: > - udp_sock_handler(&c, ref, eventmask, &now); > + udp_buf_sock_handler(&c, ref, eventmask, &now); > break; > case EPOLL_TYPE_ICMP: > icmp_sock_handler(&c, AF_INET, ref); > diff --git a/udp.c b/udp.c > index 77168fb0a2af..9c56168c6340 100644 > --- a/udp.c > +++ b/udp.c > @@ -736,7 +736,7 @@ static void udp_tap_send(const struct ctx *c, > #pragma GCC diagnostic pop > =20 > /** > - * udp_sock_handler() - Handle new data from socket > + * udp_buf_sock_handler() - Handle new data from socket > * @c: Execution context > * @ref: epoll reference > * @events: epoll events bitmap > @@ -744,8 +744,8 @@ static void udp_tap_send(const struct ctx *c, > * > * #syscalls recvmmsg > */ > -void udp_sock_handler(const struct ctx *c, union epoll_ref ref, uint32_t= events, > - const struct timespec *now) > +void udp_buf_sock_handler(const struct ctx *c, union epoll_ref ref, uint= 32_t events, > + const struct timespec *now) > { > /* For not entirely clear reasons (data locality?) pasta gets > * better throughput if we receive tap datagrams one at a > diff --git a/udp.h b/udp.h > index 087e4820f93c..6c8519e87f1a 100644 > --- a/udp.h > +++ b/udp.h > @@ -9,8 +9,8 @@ > #define UDP_TIMER_INTERVAL 1000 /* ms */ > =20 > void udp_portmap_clear(void); > -void udp_sock_handler(const struct ctx *c, union epoll_ref ref, uint32_t= events, > - const struct timespec *now); > +void udp_buf_sock_handler(const struct ctx *c, union epoll_ref ref, uint= 32_t events, > + const struct timespec *now); > int udp_tap_handler(struct ctx *c, uint8_t pif, int af, > const void *saddr, const void *daddr, > const struct pool *p, int idx, const struct timespec *now); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --3IM531mIHR+Nvth0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmXBlhAACgkQzQJF27ox 2GfPyw/+JUdP4oYLADrUJnJM9bD18o+l8VTsZrB1ZdV4ptyG0Afp0z4CMFccd8aD PVGJfuKqoCgEyP2Omqcx0FikB0te+ziyhiY5IGakEyIpPBw8WG5nHf1Qsg7Mv9Xn 19tUhfiT4zZi7cXqexI6VbdsK0weHuSvFoBXQMOsQAZD7JmhszqcauyUfnfUZ9Cv tcUWA0TsAYxk6sIXVlF1rj5QZ2uZ2WT2QCJh0TJGDlYfXoEn1umCkBVHV/lQRSvo EwWc5gEIEozQFCuz71jODY6RUx8DaHXD/MUMb9b7vkqZaKHOiSnOlMaT25fpeb33 mptnbuBnyEOuDjsOn2SRB4JCq1C0s8aaUXvIGPcEVXbFRZjqpRDodplDHlDD7OYU fAtBZTiaKRwMzrXf9V/yrGOKzew3bOuyQIryrsU/etpvhSqCroqIvfYtl+bo0IZd nc3PZQ/Xr0GC0rW12BL/Wtd63ax5tk4sPN5dWG7E7FFmHcfFmj3kBeKSpjWvxHTo s+5koTo8gx2uYGFrLv4F4LuwhFhNIb6HMU6N6+GzQJHyyokafjbFc7TbVu3LSkyG tE0PmTJ5PFnecv3soV3z8aSzxWP7bK76Ik940B+cE/QFGEhV/4F7JMoz1nnfze3g D9O/C0SjJKKEA+wWKrN6fWT1N5ZokX7OEk5bnOh3WaHFwsQL1BY= =KSJm -----END PGP SIGNATURE----- --3IM531mIHR+Nvth0--