From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 59ABD5A0272 for ; Thu, 8 Feb 2024 01:36:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1707352613; bh=fhR84KFpJVsxbtOLB4K8o5qK3U5PuUuaL4C9AwJXrtU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KCDOWR/464AcSvccoNR76I35CmqKmFp0Un2S9KcV+rJdLi3XA0NvLE3sZzzNYbPXz 9gwpvIKdDDlq5LWZRsCcE5RgRVsZ+xAvKhooSzInMR94TrcwyWxtqnnm5LK8w0/k0C RjcRUaxD1OQGTrE5PFW3NfpNOV3Bc4Yxd2B9UwMUF8RUbfBYIR0oHmsEnmhNkUo30w CfeFREuCqsjUiHVRIW3I29YLSwqfYnmJTlH834mhvzPmuJHbzTa6BwTmZh6MljxVbo UzPu1LvMB41rFH7lYdwaGcCVWKeiRNbZ/eWed+1ijsNpQP1S5LGUJY2OOKKU0jxq9Z XAqyTiAWGIvjg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4TVdN56SFfz4wyt; Thu, 8 Feb 2024 11:36:53 +1100 (AEDT) Date: Thu, 8 Feb 2024 11:04:51 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 05/24] util: move IP stuff from util.[ch] to ip.[ch] Message-ID: References: <20240202141151.3762941-1-lvivier@redhat.com> <20240202141151.3762941-6-lvivier@redhat.com> <20240207100319.24c869db@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F1XtZMAiQB8pq0Xs" Content-Disposition: inline In-Reply-To: <20240207100319.24c869db@elisabeth> Message-ID-Hash: CAJKDCUQ2QQHCKYKA7CREEZXTQEAMHNA X-Message-ID-Hash: CAJKDCUQ2QQHCKYKA7CREEZXTQEAMHNA X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --F1XtZMAiQB8pq0Xs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 07, 2024 at 10:03:19AM +0100, Stefano Brivio wrote: > Not related to the review of the patch itself: >=20 > On Mon, 5 Feb 2024 17:13:40 +1100 > David Gibson wrote: >=20 > > On Fri, Feb 02, 2024 at 03:11:32PM +0100, Laurent Vivier wrote: > >=20 > > > [...] > > > > > > +struct ipv6hdr { =20 > >=20 > > Not really in scope for this patch, but I have wondered if we should > > try to use struct ip6_hdr from netinet/ip6.h instead of our own > > version (derived, I think, from the kernel one). >=20 > The reason why I went with this is that the one in netinet/ip6.h looks > fairly unusable to me: there are no explicit fields for version and > priority, and names are long and a bit obscure, as defined by RFC 3542: > does 'ctlun' actually mean "control union"? Yeah, I did wonder about there. There are a bunch of macros to make things not so long, but the names do seem less natural. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --F1XtZMAiQB8pq0Xs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmXEGqIACgkQzQJF27ox 2GfQ6g/9GpyIMORlfTQhn38NHgbH4EhVPPo2XtOhQOMJxxKwN2PswqLGuSqtIll9 rgex4zPnOfRfE7T0T/tGudPfVqEpC9t8fvJSvwWls4kESsOZRLRoq1Ukiohedwlh TVbZTVrcpIwkDxBsLHd60wgjh8yKORnbwkclSCtfnj5ybZg0v8Hq1bbh3iq2sAFv gDqkBCtcj6r38kX1EGCGthDfHcrU/9vyAcHz5jN9NsY0h5kAXWuiHAlY38LOnztf vA3rrWu96NU4zug+z/W0FQrVWZjfCybzNUcC/OA7QVIppQ4h3SjMe+Pt2wCriEdd gRVRIKGNvvwbUyhj4HEp63c36djZfD1DpdrCh7PcmPpc11mG+lKfT3elSP4oHqNu pWWbpiGgxOw5AJq6zh1xOWg2SIR6HjwmUwXoHnW1rDL95CbYB+4NfII4+l8e761w hwnsVvWwXVysrTKwIzL4cUhHr8OyfaaVzlF5jKYj6tj9KW/WsRFCVVpHTCK7Mwnj odgFzKan/lmXjmtfloH8a9dCaFBpTKwZGzvXfN8gtmSTeMih3f3useISr0Mq2S6B 8wjhQ2+MlYikpO4nwnN5xUTr8qAjJWNdl/XOptibMTaa8Pba3DzsYMu6c5aYuoNq DJpL1OO9jh311EIwFJWYIviphBtqBLROcFCMYCHI6CD7y30IKlY= =mHDg -----END PGP SIGNATURE----- --F1XtZMAiQB8pq0Xs--