On Mon, Feb 12, 2024 at 12:18:22AM +0100, Stefano Brivio wrote: > On Tue, 6 Feb 2024 14:51:31 +1100 > David Gibson wrote: > > > On Fri, Feb 02, 2024 at 03:11:45PM +0100, Laurent Vivier wrote: > > > Add virtio.c and virtio.h that define the functions needed > > > to manage virtqueues. > > > > > > Signed-off-by: Laurent Vivier > > > > When importing a batch of code from outside, I think we need to choose > > between one of two extremes: > > > > 1) Treat this as a "vendored" dependency. Keep the imported code > > byte-for-byte identical to the original source, and possibly have > > some integration glue in different files > > > > 2) Fully assimilate: treat this as our own code, inspired by the > > original source. Rewrite as much as we need to match our own > > conventions. > > > > Currently, this is somewhere in between: we have some changes for the > > passt tree (e.g. tab indents), but other things retain qemu style > > (e.g. CamelCase, typedefs, and braces around single line clauses). > > I'd rather pick 2) if possible, in the hope that we can cut down on > lines of code, but I haven't really checked how much we use of this. Given what I've seen so far, (2) would also be my inclination at this point. I do think either one is better than something in the middle though. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson