From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 32D285A0274 for ; Mon, 12 Feb 2024 03:43:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1707705797; bh=wF/1COuGnB8mJpu4MNhC9SMt1cfAkYELoNjkg/wOERo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oddWGtwuYUGgyfHtL1MnnaZJOTeyjWB6I15jQTXN3PjuFfEOWmiIunTiD2ELNTQcR EioGokx42N7ttCSjKPg1x159Xk4ryn7OXOLFZ9qQtWluL3gRW+M25tLaFvE69OHkg7 rXn03K1HAbIaSQpLwegNBHjGDr0mFUPWbjUCTaXVJhG4ZonwE760S88qCf1jODKKXq wlO0ijkdA1aNOFJllpCAPIkHs4LU3905PVwn4hXvRxlsCnfx+bTmGcJjQ/c2+jZ7Rl jy0FMUqZCHmnLf2izvZU/NGHKX30XEsLxvs7wpthO/KJpQr4tI1DfvMoF1F20eqb52 HZJoPlJo4gFvg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4TY8052nY8z4wyk; Mon, 12 Feb 2024 13:43:17 +1100 (AEDT) Date: Mon, 12 Feb 2024 13:26:58 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 18/24] vhost-user: introduce virtio API Message-ID: References: <20240202141151.3762941-1-lvivier@redhat.com> <20240202141151.3762941-19-lvivier@redhat.com> <20240212001822.218862ff@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ncU27AMWcdU57N1I" Content-Disposition: inline In-Reply-To: <20240212001822.218862ff@elisabeth> Message-ID-Hash: HFWMDMRYHFKKX4BDBAI4U4UQZFIMLGQH X-Message-ID-Hash: HFWMDMRYHFKKX4BDBAI4U4UQZFIMLGQH X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --ncU27AMWcdU57N1I Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 12, 2024 at 12:18:22AM +0100, Stefano Brivio wrote: > On Tue, 6 Feb 2024 14:51:31 +1100 > David Gibson wrote: >=20 > > On Fri, Feb 02, 2024 at 03:11:45PM +0100, Laurent Vivier wrote: > > > Add virtio.c and virtio.h that define the functions needed > > > to manage virtqueues. > > >=20 > > > Signed-off-by: Laurent Vivier =20 > >=20 > > When importing a batch of code from outside, I think we need to choose > > between one of two extremes: > >=20 > > 1) Treat this as a "vendored" dependency. Keep the imported code > > byte-for-byte identical to the original source, and possibly have > > some integration glue in different files > >=20 > > 2) Fully assimilate: treat this as our own code, inspired by the > > original source. Rewrite as much as we need to match our own > > conventions. > >=20 > > Currently, this is somewhere in between: we have some changes for the > > passt tree (e.g. tab indents), but other things retain qemu style > > (e.g. CamelCase, typedefs, and braces around single line clauses). >=20 > I'd rather pick 2) if possible, in the hope that we can cut down on > lines of code, but I haven't really checked how much we use of this. Given what I've seen so far, (2) would also be my inclination at this point. I do think either one is better than something in the middle though. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ncU27AMWcdU57N1I Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmXJgfEACgkQzQJF27ox 2GdpeA//ffLExxUzkYVYNvDguLBFtjn2mOv91ZWyAm7iPYvnou6tqWekKqfqmAX+ SBaFMaSEDK0ADeoAkUisD2wLjynBRKl3auiBQSAb7hpYOwGyzE2n/HLQ3ZcvP2oE 2Wrpjow+KR0b0ElQ16F23j4xNMzkIlIbJ2ywFuKEo3u+4KgDKF4n5tL2nL4Cvo2P whEOJHxpEKBww0GHqE1JdWxWC9naO+Ef/tfz0zAV22mY+DgHCE4kNQIQUrbgmWGj 3egpGO+ekg+gYr1pT2dkZllWEyBQhqNumdL9AegEp37ho4vj1BGgoym7byewyEtE EJPrF7iHCWYa4RZPMqJw+ZvXQW5i9N0UotU8uHItes/n2cVaUg9TvSdE0YyYl9Pe q89IYT0N/OPf0xnYYiHa5O6/c7M2jRIkHwPAvlsx6uVLBNG48C1wm2NMvNhaihHV 3v3JQ6sr5z0/UabjqJDDHTxYxv3Tz3TwQtpxVgyv+7BIj3Sx5wNA5kx4UWpr2eEh 7Qm9cr014rQBhN3QrM8X6Ulq5OslTqXhRC+P/psIZwcq5IB/3DCS6qdP+gEPUV6r rkJfV3el+ClcurdV7OQNbt2XQ7ux2KB7Pn+OET9xBRREsZsCE6RZ+/3d8SGEcNnU znh5HwJ3FhglV31W7MN27zJcOCVAM1j3Tksnxiy6UtWs3L7inLY= =jyDq -----END PGP SIGNATURE----- --ncU27AMWcdU57N1I--