From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 9834B5A0274 for ; Mon, 12 Feb 2024 03:43:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1707705797; bh=kbwhYXIX8zybctgoJkTk81YhpZfBVPc7h8d/pGc1rJY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yomiv4x3yC7aR1kEU3jQbzuVQfRAI0d+Pi2gCzJPMCCUA6j0ik1Qkb5yomHs9EyVd sYeOxVEZZWPoo5kY8nZe+Daa62Qb2erFxIuWCEdoJe8JWVNKZKABzrwv6JT3q14333 +TVSbg4yWF9s69kOWJs4D9CWxGD/f8jjRlSBNEVQRpkFep8WA9/sDaUAo1FUubqX8v 0MVDFKCjUvkhe+xWuNdie+T0y/4//YlIpd61IncXyRjKKPb1ardgSomOzTpJFRVH2G 9Q/iLXwW98FkeZWyEYxY4Zq2Un2Er/1D2BJUqu6+aMzdlK9+l+f0rilNtU490GfXz2 tFQaGVitY9xVQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4TY8052gCyz4wyj; Mon, 12 Feb 2024 13:43:17 +1100 (AEDT) Date: Mon, 12 Feb 2024 13:22:57 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 13/24] tap: export pool_flush()/tapX_handler()/packet_add() Message-ID: References: <20240202141151.3762941-1-lvivier@redhat.com> <20240202141151.3762941-14-lvivier@redhat.com> <20240212001530.5bac9a6b@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0yQgO9Fmhoeaz/Q7" Content-Disposition: inline In-Reply-To: <20240212001530.5bac9a6b@elisabeth> Message-ID-Hash: X3CHTJNNMRSA7MWD4IGET6LRMVYKPT3E X-Message-ID-Hash: X3CHTJNNMRSA7MWD4IGET6LRMVYKPT3E X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --0yQgO9Fmhoeaz/Q7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 12, 2024 at 12:15:30AM +0100, Stefano Brivio wrote: > On Fri, 2 Feb 2024 15:11:40 +0100 > Laurent Vivier wrote: >=20 > > From: Laurent Vivier > >=20 > > Signed-off-by: Laurent Vivier > > --- > > tap.c | 98 +++++++++++++++++++++++++++++------------------------------ > > tap.h | 7 +++++ > > 2 files changed, 56 insertions(+), 49 deletions(-) >=20 > I'm assuming that you need this patch to recycle those bits of "tap" > functions for usage in vhost-user code... which shows they actually > have little to do with tun/tap interfaces. >=20 > But sure, we already have there stuff to deal with UNIX domain sockets, > so "tap" is already somewhat inconsistent. >=20 > If use "tap" for a (long) moment to denote "anything guest/container > facing", then: We're definitely doing that at present. I am wondering with adding this third "tap" option that's even further from tuntap whether we should rethink that naming convention. I was contemplating something along the lines of "l2if" emphasizing that the thing in common is that it's a transport operating at L2 level, unlike the "sock" side operating at l4. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --0yQgO9Fmhoeaz/Q7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmXJgPwACgkQzQJF27ox 2GdpiA//ZJINM5kSCLoe0snmmfBSxhotl/BWDQBgDlyro+dprPXJaDT8ZPeShCCj KcUY3RPENls2AKnUL3Cc2aKZmVRGctCOzde+PcRbX/4VzPdU88KttaHRNfXyhgAK 4un9snchVzPBm5m1uq8yxVGJOuJD8JiSDtQn6m6E5kab9rrmTb65yS1rhL5R5iOm acwal+ZsiV9yKz5wZINc2i5VOiyqt1soQgVCGoVIYo8I2mAHzLHpq9PeaGRtgoHq JSFP7nrJlSXrp28N1RfUgZ0NuG7EsEGrnFeuxDVuOUSgEUIl/QRp8ZQpSqVjiPTF JvbGIe5DstSjjjozRWPQXEgZGHTN9mpdSUqKv67WGajk1bDrIlIHBsaiPXeX8AfE ce8nudGMuAQl73a7uxiCw466Pg/7GggguqJBeRqmvQu6vSbvIkI5SI0UOX/UNvSP ou4Y74YusShDFJwdiuLYjTGoiON0XHTBwVE2Vy+nCXnOZXlygQmfdRfm/YG1Uts+ b8xvB9Hh+sJJoDWClc4HVXIJKdc3uwd+JZJKi+ziHdGLnW2rCOOFsV5fNgosPkFA TqzA672xqZspaTLz9doMl2F2RTjuisbaeUGBYGQ6CNQxdbFSrM3nW14yGik5AgQA z5aZs78HA65OgCfFwvBkObQUFeL80IttlebsL0O2Ba/k4Xykg9M= =bmwS -----END PGP SIGNATURE----- --0yQgO9Fmhoeaz/Q7--