From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 1971B5A027D for ; Wed, 14 Feb 2024 03:10:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1707876601; bh=oKwGnkY6+AXwq6qMbrgrI/CCJwLS1zssJytqbFUsQoM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=guZJH3oExJ3EI0USleUglIcuuxzK01/DuRAhBbtvfgIhjfN5jfZ6nQ7i5yhPVzMo9 3jLmusQIzPdFXK9AHY6CEhkjSMkQX7TiPvbuKnO2AdjfnYJEThu8MH/ihgZ+2LTNxa WSrKxwOWv5+j0g2ppPumGGCg1H3b8oaE6VSZrrZs5ppEzPirgdEoPR6RcS95+H3bBw vMEh3WzGtGiO7An5hKiFe9WbROggs+GLTBw15MsxQtpez5mUN3+bwnN2wnTDPnG3Vg GJDWFgnsep43HFVRfgDQ/iBu/iucX6FQG7agS5nFQphw3Ksyb95bMdVwxedMjDz2hH VeBVVw9c1JTfw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4TZM8n6tX8z4wcr; Wed, 14 Feb 2024 13:10:01 +1100 (AEDT) Date: Wed, 14 Feb 2024 13:05:50 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 20/24] vhost-user: add vhost-user Message-ID: References: <20240202141151.3762941-1-lvivier@redhat.com> <20240202141151.3762941-21-lvivier@redhat.com> <20240212001922.1baf3db0@elisabeth> <20240213162256.0407fd8f@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9EB3ZjPaf/X5k13m" Content-Disposition: inline In-Reply-To: <20240213162256.0407fd8f@elisabeth> Message-ID-Hash: RCODNRNDHD5WSQDJ2NOHVZF643Q3TCZP X-Message-ID-Hash: RCODNRNDHD5WSQDJ2NOHVZF643Q3TCZP X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --9EB3ZjPaf/X5k13m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 13, 2024 at 04:22:56PM +0100, Stefano Brivio wrote: > On Mon, 12 Feb 2024 13:47:15 +1100 > David Gibson wrote: >=20 > > On Mon, Feb 12, 2024 at 12:19:22AM +0100, Stefano Brivio wrote: > > > On Wed, 7 Feb 2024 13:40:33 +1100 > > > David Gibson wrote: > > > =20 > > > > On Fri, Feb 02, 2024 at 03:11:47PM +0100, Laurent Vivier wrote: =20 > > > > > add virtio and vhost-user functions to connect with QEMU. > > > > >=20 > > > > > $ ./passt --vhost-user > > > > >=20 > > > > > and > > > > >=20 > > > > > # qemu-system-x86_64 ... -m 4G \ > > > > > -object memory-backend-memfd,id=3Dmemfd0,share=3Don,size= =3D4G \ > > > > > -numa node,memdev=3Dmemfd0 \ > > > > > -chardev socket,id=3Dchr0,path=3D/tmp/passt_1.socket \ = =20 > > > >=20 > > > > I think it would be wise to use different default socket names for > > > > vhost-user than for the qemu socket protocol. =20 > > >=20 > > > I'm not sure if there's an obvious benefit (mix them up, and nothing > > > will work anyway). On the other hand, that means more typing and > > > remembering what's the separator between "passt", "vhost", and "user". > > > =20 > > > > Or even to require > > > > --socket-path: the reasons we have these rather weird default probed > > > > paths don't apply here, AFAICT. =20 > > >=20 > > > Why not, actually? With probed paths, you can still reasonably start > > > passt by *typing* its command line. I do it all the time, and I think > > > it's quite nice to have. =20 > >=20 > > Uh.. I'm not sure how this would change that. >=20 > Because one would have to type: >=20 > ./passt --vhost-user --socket-path /tmp/passt.something Well.. it could be: ./passt --vhost-user -s foo You can use the shorter option, and the socket doesn't have to be in /tmp (in fact, I'd argue it's usually better not to put them there). This also means you can use your (possibly shorter) choice of socket name on the qemu command line. > instead of ./passt --vhost-user? Sure, sometimes I call my sockets > /tmp/s, but still that doubles the length of the command line. >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --9EB3ZjPaf/X5k13m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmXMH/0ACgkQzQJF27ox 2GfVWw//VuPxe35sh6oVvUl2/7XnjIfoU1jBg4ldgAs//JhBGyjjfXdGdHVNWODi yPuWPhRmqNc/rH1iqgceY8SjLHnLZNo7I7k/IamSxUdZ+1Kza7ucPInbMDsRYw6w DHJVBk5DjkLXYDH1judvgaU/Qj8kHrzbumrxpN6KW71KQoxxq/+WG878xKHKQXVa aXTynAZCHM4mllN0uW+ciym/sE2yNqiItMe+qEP6/Z/kaWRBm79eCHPYSyR5liG0 4mwWfmBgKp9/3CIDz0YZj71sS4UyurMOKsEla/Lqr/v+KqJpFy9A8h5lm66RCR5Z 2LvJX5gbbMI+xpDWYYbnqzuctFDvEzqxVopDl9Xkzy0LfFe93wQBNdyoAzPv/IvH IqNPvxKZ52PVdHsua/0WHQ3k49MJBSGfcsyIW53h6ViP41xu4eR2zz6+3/6iTArX Bzli1H6IRyyOpoU8tHPx+V/ICMVuLL038YuEj8Pk8oA5KjyzwfO9RuPRl7Z2UB4N SBE1dVqKrSUCY6k6ph/ifSdsK2Ps1n2b82piTz0yB/1ytDN5TcuKUbO9U4yc+3rb GUhzzeSFKf/W+bV57iedcifXE+XeGECd7xJV0sj14DVh1E7Zk0qOEHYe4Ks3ACSp 1StrgssEijoci3X+LPGxbcv57QNglEQDNIzam1r+180LlEhK2tg= =7zUU -----END PGP SIGNATURE----- --9EB3ZjPaf/X5k13m--