From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id EF97D5A0271 for ; Tue, 27 Feb 2024 22:25:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1709069116; bh=rK9hCoZyx6RQGotYKUo3e6jmwahQ9582QyF4np3sONs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BwQOY1w3NMomacz3S1Mu58c9uedOFHq/WkQ8RB2ZxQ2W2O/BtM+mEhW8efGsFJHkV OHvP72Pfa5AANGGlGDvECs6RSEDcZ5K8CVG9QgsZsVdzY26Ntv0RT2/CoPKOg+Y+/y 01HL3oKVwhMBuxZDckA/IKQVqyPtZKMpLE3AXJXqNHCdgIFc0B0vZfA0XFgzzba25a OC+O7Odxw8qZIV7q1M7Z8t+EAw2luOyuJGPOHkPq9wbrMvcVks1PC6HKOU8AvUON7E txV1g6Iks7xyRpSHC3NIJ4jA3fdAD7jfqAag65wUynoqRjyEtx6uTAR/V4pF3PKe7M G8EYo2Zr+6c2Q== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Tkr9m3Hx9z4wcN; Wed, 28 Feb 2024 08:25:16 +1100 (AEDT) Date: Wed, 28 Feb 2024 08:25:12 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] conf: If no interface with a default route was found, say it Message-ID: References: <20240227162949.2442048-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3LfbTdMkzIy8USHM" Content-Disposition: inline In-Reply-To: <20240227162949.2442048-1-sbrivio@redhat.com> Message-ID-Hash: NRAJPDIL2SMOKT3Q6HKB54WZFSPU236Y X-Message-ID-Hash: NRAJPDIL2SMOKT3Q6HKB54WZFSPU236Y X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --3LfbTdMkzIy8USHM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 27, 2024 at 05:29:49PM +0100, Stefano Brivio wrote: > ...instead of implying that by stating that there's no routable > interface for a given IP version. There might be interfaces with > non-default routes. >=20 > Suggested-by: Paul Holzinger > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > conf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/conf.c b/conf.c > index 17cf279..fb77272 100644 > --- a/conf.c > +++ b/conf.c > @@ -565,7 +565,7 @@ static unsigned int conf_ip4(unsigned int ifi, > ifi =3D nl_get_ext_if(nl_sock, AF_INET); > =20 > if (!ifi) { > - info("No routable interface for IPv4: IPv4 is disabled"); > + info("No interface with a default route for IPv4: disabling IPv4"); > return 0; > } > =20 > @@ -637,7 +637,7 @@ static unsigned int conf_ip6(unsigned int ifi, > ifi =3D nl_get_ext_if(nl_sock, AF_INET6); > =20 > if (!ifi) { > - info("No routable interface for IPv6: IPv6 is disabled"); > + info("No interface with a default route for IPv6: disabling IPv6"); > return 0; > } > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --3LfbTdMkzIy8USHM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmXeUzcACgkQzQJF27ox 2GfvsxAAi+0UhhMNzrVVJCozqQJu2+MrJbE8RsgqyilyjdD4yRFymSlyFLTsSyJG 6s8BfLHGgdvFh9JypXHc4Y2n6dV7DSeG/0PdFygSowN6xEM7lRKMfkb7dJgC+6Wk AvidNlPxfMhDONxjoD6IcMvTcR+LxvpsxBsUdVWJ69/1UdIcBT//O5zzQK92ph7U NHACnsp5KnJNc68B+FLixWYhrBKuyrSC1J47ZvBTPVQrh8rAlBTSpkCcnuCO8t6o IEDkfiWq0hWD/u1OT3wAKfOwKHOlymDP0tHFAlcLCXoc2qgzhaY3wNwaLCsKsSof yBlRfA6G2niz0RHr6h5DLgGn8L1Z4uG6k5MwhLwvuERFQdfi5TDUvzkPvx/+239i SojzZB1r6llCG3lMAg2iiiLlLOObjacG9YWW/lSvPGw4zsx5raNhPktdYzTJsxlK LzKFW88Ikqkaq34edLrVblSFRtOOCqDu/mk6Ynz+Q2b8isHnIVGeJNXxBwrpAWuN 10PVxPayIWZVC8G2aagjFxohrGm+9AEDtwRZdukCkFZ4SsISvONAWRyPx2nyBI+c nL31yicNLkA01P+yaUOyWPPoNlCKQhnnYRfhc2T6Y181yijjnJYmPtiIy/TwFJ+l i3JN0EKoOCBHiE/FdIVbEHkPzy+RQQZsvPvZvvN5dW3aQh5Ql+4= =SYTo -----END PGP SIGNATURE----- --3LfbTdMkzIy8USHM--