* [PATCH] conf: If no interface with a default route was found, say it
@ 2024-02-27 16:29 Stefano Brivio
2024-02-27 21:25 ` David Gibson
2024-02-28 10:18 ` Paul Holzinger
0 siblings, 2 replies; 3+ messages in thread
From: Stefano Brivio @ 2024-02-27 16:29 UTC (permalink / raw)
To: passt-dev; +Cc: Paul Holzinger
...instead of implying that by stating that there's no routable
interface for a given IP version. There might be interfaces with
non-default routes.
Suggested-by: Paul Holzinger <pholzing@redhat.com>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/conf.c b/conf.c
index 17cf279..fb77272 100644
--- a/conf.c
+++ b/conf.c
@@ -565,7 +565,7 @@ static unsigned int conf_ip4(unsigned int ifi,
ifi = nl_get_ext_if(nl_sock, AF_INET);
if (!ifi) {
- info("No routable interface for IPv4: IPv4 is disabled");
+ info("No interface with a default route for IPv4: disabling IPv4");
return 0;
}
@@ -637,7 +637,7 @@ static unsigned int conf_ip6(unsigned int ifi,
ifi = nl_get_ext_if(nl_sock, AF_INET6);
if (!ifi) {
- info("No routable interface for IPv6: IPv6 is disabled");
+ info("No interface with a default route for IPv6: disabling IPv6");
return 0;
}
--
@@ -565,7 +565,7 @@ static unsigned int conf_ip4(unsigned int ifi,
ifi = nl_get_ext_if(nl_sock, AF_INET);
if (!ifi) {
- info("No routable interface for IPv4: IPv4 is disabled");
+ info("No interface with a default route for IPv4: disabling IPv4");
return 0;
}
@@ -637,7 +637,7 @@ static unsigned int conf_ip6(unsigned int ifi,
ifi = nl_get_ext_if(nl_sock, AF_INET6);
if (!ifi) {
- info("No routable interface for IPv6: IPv6 is disabled");
+ info("No interface with a default route for IPv6: disabling IPv6");
return 0;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] conf: If no interface with a default route was found, say it
2024-02-27 16:29 [PATCH] conf: If no interface with a default route was found, say it Stefano Brivio
@ 2024-02-27 21:25 ` David Gibson
2024-02-28 10:18 ` Paul Holzinger
1 sibling, 0 replies; 3+ messages in thread
From: David Gibson @ 2024-02-27 21:25 UTC (permalink / raw)
To: Stefano Brivio; +Cc: passt-dev, Paul Holzinger
[-- Attachment #1: Type: text/plain, Size: 1379 bytes --]
On Tue, Feb 27, 2024 at 05:29:49PM +0100, Stefano Brivio wrote:
> ...instead of implying that by stating that there's no routable
> interface for a given IP version. There might be interfaces with
> non-default routes.
>
> Suggested-by: Paul Holzinger <pholzing@redhat.com>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> conf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/conf.c b/conf.c
> index 17cf279..fb77272 100644
> --- a/conf.c
> +++ b/conf.c
> @@ -565,7 +565,7 @@ static unsigned int conf_ip4(unsigned int ifi,
> ifi = nl_get_ext_if(nl_sock, AF_INET);
>
> if (!ifi) {
> - info("No routable interface for IPv4: IPv4 is disabled");
> + info("No interface with a default route for IPv4: disabling IPv4");
> return 0;
> }
>
> @@ -637,7 +637,7 @@ static unsigned int conf_ip6(unsigned int ifi,
> ifi = nl_get_ext_if(nl_sock, AF_INET6);
>
> if (!ifi) {
> - info("No routable interface for IPv6: IPv6 is disabled");
> + info("No interface with a default route for IPv6: disabling IPv6");
> return 0;
> }
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] conf: If no interface with a default route was found, say it
2024-02-27 16:29 [PATCH] conf: If no interface with a default route was found, say it Stefano Brivio
2024-02-27 21:25 ` David Gibson
@ 2024-02-28 10:18 ` Paul Holzinger
1 sibling, 0 replies; 3+ messages in thread
From: Paul Holzinger @ 2024-02-28 10:18 UTC (permalink / raw)
To: Stefano Brivio, passt-dev
On 27/02/2024 17:29, Stefano Brivio wrote:
> ...instead of implying that by stating that there's no routable
> interface for a given IP version. There might be interfaces with
> non-default routes.
>
> Suggested-by: Paul Holzinger <pholzing@redhat.com>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: Paul Holzinger <pholzing@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-28 10:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-27 16:29 [PATCH] conf: If no interface with a default route was found, say it Stefano Brivio
2024-02-27 21:25 ` David Gibson
2024-02-28 10:18 ` Paul Holzinger
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).