From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 8724C5A0278 for ; Mon, 19 Feb 2024 03:07:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1708308465; bh=5koaS7wmVJ80wNH1OjE2Q29Y4L2NB8RiFEREB7LLwX0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KdE1ViUNbOnsbNEP4Zy3nOU5UD1Cd/GBVt6BpzBRgKx2jyaUOnOP7Emh2W+uWIO8l xbpLScXgXj1svk6b1EAyNzsHUhGHF46Msv2xBD6xaTAloMmnZlhtAkPW7MwcGeZDaC dxvZse6YIHk+jm0CDr/qDgE+c3njvjSXwLsy/ncEfsygn6mf9HI0BpabXdLWSR5FEV lkbhNeuy0DttZucXGBjYQHm0SRaOcVw43hH2A9xscN3zFrMCTKiU5RdeFAar0kQKb4 Na3gSDG/Lji5WNfYqC+A2ptZGVFcQQLK3lR0AiJUBFlqPT37Sc8pmpstOYyJsdxf4/ c0/5cT9lCQ6Tg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4TdQss4HH1z4wcB; Mon, 19 Feb 2024 13:07:45 +1100 (AEDT) Date: Mon, 19 Feb 2024 13:06:50 +1100 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v2 6/8] checksum: use csum_ip4_header() in udp.c and tcp.c Message-ID: References: <20240214085628.210783-1-lvivier@redhat.com> <20240214085628.210783-7-lvivier@redhat.com> <20240216100805.040826b3@elisabeth> <53d4a403-0d3f-4aa0-b980-27c2026a468b@redhat.com> <20240216155400.1d26ae17@elisabeth> <7a9915cf-f004-453a-b328-80d086c14a80@redhat.com> <20240216192440.6031e2d2@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7Je7Ca/pem8UD0LR" Content-Disposition: inline In-Reply-To: Message-ID-Hash: SOV4PJHG2U7MABI5UQF2LPOSSE5SMFVW X-Message-ID-Hash: SOV4PJHG2U7MABI5UQF2LPOSSE5SMFVW X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Stefano Brivio , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --7Je7Ca/pem8UD0LR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 17, 2024 at 03:22:12PM +0100, Laurent Vivier wrote: > On 2/16/24 19:24, Stefano Brivio wrote: > > On Fri, 16 Feb 2024 19:05:39 +0100 > > Laurent Vivier wrote: > >=20 > > ... > > > I think I will send the v3 of my series without fixing that because I= don't have enough > > > time this week. I will address the problem later. > > No problem! I will also try to spend a moment and see if there's some > > reasonable solution I can suggest. Thanks, > >=20 > I can imagine 4 solutions: >=20 > * to use inline functions (could it helps the compiler to manage the ali= gnment problem?) > * to use C macros > * to use these new functions only with vhost-user as we know pointers wi= ll be aligned. > * to include structure we want to address in a generic wrapperstructure = that will > unalign it as it is done with the current structure. I think some of my earlier comments suggested passing some values, rather than reading them from the iph - this would take us closer to the "feed" style of csum calculation that we already use for siphash. As a side effect, I think that will sidestep at least some of these problems. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --7Je7Ca/pem8UD0LR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmXSt7kACgkQzQJF27ox 2GdADg/+Oe08FeplkBqUaBSfjC3+JYyt69r92rb5Kv1tOq792BSgAvZ64Qa5Gu+p P9P4cekxPlgYtvRPBCwgZNxAYVAnD6jMeVjan222higXdAAGfVIg48QSJ4Zmyiqr jjH/Fho7PIt9gaARDxr6dS3q1C6cl1JgMK0k9hEeReNz372/3/t7fGUtrGrCz8Am 3CZgTAsvl4FOE6ce4vzCynOODnX/3xB88fvIRDa9AwOkcELA8PWnZ5dIb/s0r5uz 8kTqhjgYBu4nNLkvpMzB3PudTv/NvDc58KVVMomtX+BS06e36MsaGjDih2y4MUSX AdprRgHY4Q1QGlAvIqAtjDKCCX0lFaqo9/2+g81q7I4czgzSUH5JKg8TQcUzs8iJ CzEyOmC1Jcc+wZ+9jG9ES8anAvv6jdOc3Xw7YCOofei9q5c9WPXa6PheamhYmyos Z4q4mMy8IkniwnT31biGpoKqmPTzJWygGzz0aeuVRt5+R7Tyq9B5rQFmjAd88rSX zBM84FT2CNrorle4qfaSapFVYwinmOyPwy2qk33THq33kMtC0ZHHNaFG6i+21NdV znrf1ZyHQ8KuinedmY+F4mj8t2wEGlEXYHqmug0qQUtpBQ7bH4Ri31oipqApd96V 24h5Eq8CMQb1HO7J9lwJsJ6tSwjLc1rryDQt87Fz6Mhh34c18lY= =3ext -----END PGP SIGNATURE----- --7Je7Ca/pem8UD0LR--