Re: [PATCH 1/2] passt: make --quiet set the log level to warning

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

On Thu, Feb 22, 2024 at 06:17:39PM +0100, Paul Holzinger wrote:
> Based on the man page and help output --quiet hides informational
> messages. This means that warnings should still be logged. This was
> discussed in[1].
> 
> [1] https://archives.passt.top/passt-dev/20240216114304.7234a83f@elisabeth/T/#m42652824644973674e84baf9e0bf1d0e88104450
> 
> Signed-off-by: Paul Holzinger <pholzing@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

in terms of implementing what it says it does.  Stefano, your call on
whether this is something we want to do, or whether updating the docs
would be better.

> ---
>  passt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/passt.c b/passt.c
> index a90568f..5d7e7c4 100644
> --- a/passt.c
> +++ b/passt.c
> @@ -326,7 +326,7 @@ int main(int argc, char **argv)
>  	if (c.debug)
>  		__setlogmask(LOG_UPTO(LOG_DEBUG));
>  	else if (c.quiet)
> -		__setlogmask(LOG_UPTO(LOG_ERR));
> +		__setlogmask(LOG_UPTO(LOG_WARNING));
>  	else
>  		__setlogmask(LOG_UPTO(LOG_INFO));
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]