From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 89BE65A0276 for ; Fri, 23 Feb 2024 09:12:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1708675925; bh=7HFnDNxz8y6hgkw56Zc619/b3HeZG2nWrhl0Rr+DrMI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H1ppWrv7+GDHPekcrscjfyaSgvgl7TyRq4exjaNBYvoiTFS41nk5wc7ONoj3h+p7h zrcNHZWX7HevmAiMXhnRjguJ8r5I67hCGDQe/supC4xM9ZEZ2WUmI4x2dgBm6c/LQz dRamfZWRDae5O2XYK1EZ2FpdT4oFg/FoTr893Kr+tlzAHj2pfYMJuBtrxeC/myT+U0 cUFXVGJrHHfudTEzA5uzIXh+huYJeHuvYD1opRJ+mTrlp54S6aGN6oLOvhTnF/J3hs R/GM4ra3DSL0zxgGyMK6bsBkK4PtXS40pflp7bK4pbC7ZK470X3DC6UOtTJlEy8ISo vDKL8FrdJ5XWQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Th2mP4rQXz4wnp; Fri, 23 Feb 2024 19:12:05 +1100 (AEDT) Date: Fri, 23 Feb 2024 19:12:00 +1100 From: David Gibson To: Paul Holzinger Subject: Re: [PATCH 1/2] passt: make --quiet set the log level to warning Message-ID: References: <20240222171739.141623-2-pholzing@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vosr1ZKMZGNtqK0i" Content-Disposition: inline In-Reply-To: <20240222171739.141623-2-pholzing@redhat.com> Message-ID-Hash: ORK2Q75GA2OBWAXBGCK43NW3MXOF5GFR X-Message-ID-Hash: ORK2Q75GA2OBWAXBGCK43NW3MXOF5GFR X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --vosr1ZKMZGNtqK0i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 22, 2024 at 06:17:39PM +0100, Paul Holzinger wrote: > Based on the man page and help output --quiet hides informational > messages. This means that warnings should still be logged. This was > discussed in[1]. >=20 > [1] https://archives.passt.top/passt-dev/20240216114304.7234a83f@elisabet= h/T/#m42652824644973674e84baf9e0bf1d0e88104450 >=20 > Signed-off-by: Paul Holzinger Reviewed-by: David Gibson in terms of implementing what it says it does. Stefano, your call on whether this is something we want to do, or whether updating the docs would be better. > --- > passt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/passt.c b/passt.c > index a90568f..5d7e7c4 100644 > --- a/passt.c > +++ b/passt.c > @@ -326,7 +326,7 @@ int main(int argc, char **argv) > if (c.debug) > __setlogmask(LOG_UPTO(LOG_DEBUG)); > else if (c.quiet) > - __setlogmask(LOG_UPTO(LOG_ERR)); > + __setlogmask(LOG_UPTO(LOG_WARNING)); > else > __setlogmask(LOG_UPTO(LOG_INFO)); > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --vosr1ZKMZGNtqK0i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmXYU0MACgkQzQJF27ox 2Gfj8w/+LjFAhYnv/6fqfUU6peFsXQbIiitET1fD3Pqpxd6YdXoC3By/+ZxVF2Ch DC2+I6cRBTRsbpRQjXEVZeivp/xHO0255hzieiG19BmOyCr1GwJek3f8k4HPzAK5 tErdFnsZQOoRbBOB5d0M/p5aImIuhoY8rqAHS02h9riD3fME6G5K0mlWZA41E6hp M1pgICnHtY44K52GYSvn2NL3/OzJrjnKuDcjO9quOt/xvzQNLhK6NJVVFoq5TPwX mpgdGtftSRdaclY6TbUHsUurd3mDOTYbfaOPTbZQgOgI9+tg7erWW06BWy3SIrnJ GkucwDn0MkgvlfJw7YUKochJiljYrMGruCbpazHLOZCzy/jzqeZCLq5Hr+eTSHiq CQb0wVxObuEiJUzlzdxCQY0c3j3FtBRUQ/7P1cIGccQQRJ2RrYRRaNc8wSBj0ygU jxdfZ2olz20uQ4r1x5Lr/uFT11G6nxjDyPR93XHNHrv+nr5CIRZN7iDyVBLNWHe5 SAtHgV167zFuKNCCwpwNg1opNbiL4HfzqukAj1ddSJne0Ia8YUMzXOLqtRfDiAnX PPY5fBhpIWrnj1kjTUKFLne7+Zal2kO0AjAnbUlrIRaZXWwTtKXrSxYHTWP8ckOD kLclvzxWuTfhP3up3YXrqrsEXnbbiySPvMDBruzlRgD00NMMnWg= =EHXr -----END PGP SIGNATURE----- --vosr1ZKMZGNtqK0i--