Re: [PATCH v4 4/8] util: move IP stuff from util.[ch] to ip.[ch]

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

On Thu, Feb 29, 2024 at 05:59:51PM +0100, Laurent Vivier wrote:
> Introduce ip.[ch] file to encapsulate IP protocol handling functions and
> structures.  Modify various files to include the new header ip.h when
> it's needed.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> 
> Notes:
>     v4:
>       - rebase
>     
>     v3:
>       - rewrap rationale
>       - add David's R-b
>     
>     v2:
>       - update rationale and comments
> 
>  Makefile     | 10 +++---
>  conf.c       |  1 +
>  dhcp.c       |  1 +
>  flow.c       |  1 +
>  fwd.c        |  1 +
>  icmp.c       |  1 +
>  inany.c      |  1 +
>  ip.c         | 72 +++++++++++++++++++++++++++++++++++++++++++
>  ip.h         | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++

Noe that ip.h exists, in4addr_loopback and in4addr_any should probably
go in there rather than inany.h.  That can be a followup change
though.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]