From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id B57A95A0278 for ; Fri, 1 Mar 2024 00:42:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1709250137; bh=NWzPEzUi4v0UzJX3Ylx1Ti8oLORYS5MaS/adDYysR5c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HApnj96ozzBY/oMs9aFhaRQLkC9pBHiMijLqzm2cG4wI3F8aZXsRWTTfH4ynQs5sI FkBYT2WkVSMeHrX7cEDkj1iuKkPw0A41lCY3yIhDzwLmE2r6Crr4yYl9fv9W0G66Vq BjHomAc0gOWgjo4q0tiZs/xH91cV4kmOMEKLmpiMKo45Gm+atqZv1OEg+ky3ZClGLp 169D+Cm+J8Xqk/O6RPSI50IEKDEijkOIS19mUJXJ1S1ESwBk1DqbwhFg1Pcqb53RwM kJ50qp49Kx53QURb42zd6lG7R8jEmPZ1Go/EwkYGCg435mkPGevst06/RiUNTHRRtH qoxDS3VJzExPw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Tm76x2HNWz4wck; Fri, 1 Mar 2024 10:42:17 +1100 (AEDT) Date: Fri, 1 Mar 2024 10:19:51 +1100 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v4 4/8] util: move IP stuff from util.[ch] to ip.[ch] Message-ID: References: <20240229165955.829476-1-lvivier@redhat.com> <20240229165955.829476-5-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XVgaB8UUDiWJHFJP" Content-Disposition: inline In-Reply-To: <20240229165955.829476-5-lvivier@redhat.com> Message-ID-Hash: YBV64M3W7XMQAGQHLV5RNRASMPRVCTSG X-Message-ID-Hash: YBV64M3W7XMQAGQHLV5RNRASMPRVCTSG X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --XVgaB8UUDiWJHFJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 29, 2024 at 05:59:51PM +0100, Laurent Vivier wrote: > Introduce ip.[ch] file to encapsulate IP protocol handling functions and > structures. Modify various files to include the new header ip.h when > it's needed. >=20 > Signed-off-by: Laurent Vivier > Reviewed-by: David Gibson > --- >=20 > Notes: > v4: > - rebase > =20 > v3: > - rewrap rationale > - add David's R-b > =20 > v2: > - update rationale and comments >=20 > Makefile | 10 +++--- > conf.c | 1 + > dhcp.c | 1 + > flow.c | 1 + > fwd.c | 1 + > icmp.c | 1 + > inany.c | 1 + > ip.c | 72 +++++++++++++++++++++++++++++++++++++++++++ > ip.h | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++ Noe that ip.h exists, in4addr_loopback and in4addr_any should probably go in there rather than inany.h. That can be a followup change though. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --XVgaB8UUDiWJHFJP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmXhERYACgkQzQJF27ox 2GeRBBAAnzKIFK/kAUgqNQT48Q2VrcKSMoYLmQEE/qPxFrX30g9EyIEaR6rNruXo +nHAXYzAO/vGa0ETYC9/gmjny3NOcZX6ZCw27VV7Ell1f2fSNhc0mFtAbQQb51Gg KNGx3bIwUiDAUzTBhTyAx4L/gVkIA4YorFF/S+Es1Acti2fMn3r0+kHsOAviKhRC mILq/XzyvmC3skgogpFaCae+xdinDg281/oL0BqEJcnsEL9fLTKn9sBmFUmSvYZG Spd0K5W4Hv3HXd77xDE2iJV8j8NVvkVhpu40og+j7uJBjkzpABFJi+tfguwyTQkD w6gGZHJCwyIuDidpAgNxN1kR4bZ/iIIoIPUSbCocjDPpnwkVAfcNGoWLtiDvoSEs Q1c6dCVlHHWU+n2SkPdT4o7QhQLwv/SpM0IdKL06pRsaIeKR33QSbl2Hq/t36IOA KYhjCiepP0pS+EWf4xC1N4jH5LNRIOGQQuOFti8qOBqCE0y//OkI0aofVqHaKDE5 FGvAHPJdViO6EoTUf/tgYOowP8F2iQDSSljAuUdVt07rksdC8gbSQqjclt3UjY2Y WBGlzfkfyefFPfnbCOe+U17gFHCVX5kVpjK6HbtPO1OSu5hGYEornUYIgUyvM2dP H/1FExcaMM/vu1NuwN6u9lCDqOECr/V0ayUxwIFYusX61oY9u/k= =Ws01 -----END PGP SIGNATURE----- --XVgaB8UUDiWJHFJP--