Re: [PATCH] passt.1: --{no-,}dhcp-dns and --{no-,}dhcp-search don't take addresses

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2091 bytes --]

On Tue, Mar 12, 2024 at 07:21:26PM +0100, Stefano Brivio wrote:
> ...they are simple enable/disable options.
> 
> Fixes: 89678c515755 ("conf, udp: Introduce basic DNS forwarding")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  passt.1 | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/passt.1 b/passt.1
> index e97ef73..9c492f5 100644
> --- a/passt.1
> +++ b/passt.1
> @@ -237,28 +237,28 @@ list altogether (if you need to search a domain called "none" you can use
>  \fB--search none.\fR).
>  
>  .TP
> -.BR \-\-no-dhcp-dns " " \fIaddr
> +.BR \-\-no-dhcp-dns
>  In \fIpasst\fR mode, do not assign IPv4 addresses via DHCP (option 23) or IPv6
>  addresses via NDP Router Advertisement (option type 25) and DHCPv6 (option 23)
>  as DNS resolvers.
>  By default, all the configured addresses are passed.
>  
>  .TP
> -.BR \-\-dhcp-dns " " \fIaddr
> +.BR \-\-dhcp-dns
>  In \fIpasta\fR mode, assign IPv4 addresses via DHCP (option 23) or IPv6
>  addresses via NDP Router Advertisement (option type 25) and DHCPv6 (option 23)
>  as DNS resolvers.
>  By default, configured addresses, if any, are not passed.
>  
>  .TP
> -.BR \-\-no-dhcp-search " " \fIaddr
> +.BR \-\-no-dhcp-search
>  In \fIpasst\fR mode, do not send the DNS domain search list addresses via DHCP
>  (option 119), via NDP Router Advertisement (option type 31) and DHCPv6 (option
>  24).
>  By default, the DNS domain search list resulting from configuration is passed.
>  
>  .TP
> -.BR \-\-dhcp-search " " \fIaddr
> +.BR \-\-dhcp-search
>  In \fIpasta\fR mode, send the DNS domain search list addresses via DHCP (option
>  119), via NDP Router Advertisement (option type 31) and DHCPv6 (option 24).
>  By default, the DNS domain search list resulting from configuration is not

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]