From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 31EFD5A026F for ; Thu, 14 Mar 2024 03:17:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1710382641; bh=qOr3JTgSi0ZLfkwh5ItyFjwsbNiOa3WkVx6xmlTmbdg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QCGaYFgQdaEKcMlOVmIuTn3oF+jnTbCl9wyrTIIvWQ7CXSPH3lBbUORlCzaPKBnCC xfy286+Red3+s/kZfWP6IkItIuoM2doPtBynsODRAYWPuu6Nd7JAngWlWH1rRd9ssW WSqaQuq/XM5MWaT5v5AEWbf21EuQqxmWDUitL53LiVn7Lcn6ZZwLmB2HO+4hwhpLbl arl53Vldr/e2NZSnzyxjbksADuCJmIh5pL8xiMN43sPBdXfJ5C2XewSm0xYc8Sc1Vz sQVeGYlK6/7JX6UUq4NtBbqDbH4IgE+wqzbEfIPw1e/DX31h9H0UBLgvJ1p+eHUZWi jyVR4NyZHQg3Q== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Tw9xs5r15z4wcr; Thu, 14 Mar 2024 13:17:21 +1100 (AEDT) Date: Thu, 14 Mar 2024 13:13:05 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] passt.1: --{no-,}dhcp-dns and --{no-,}dhcp-search don't take addresses Message-ID: References: <20240312182126.510726-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="g3W8XB1TZSq6whAq" Content-Disposition: inline In-Reply-To: <20240312182126.510726-1-sbrivio@redhat.com> Message-ID-Hash: FKAT3XIPW3XMIQB3L4KOHHSZBZQEDIBJ X-Message-ID-Hash: FKAT3XIPW3XMIQB3L4KOHHSZBZQEDIBJ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --g3W8XB1TZSq6whAq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 12, 2024 at 07:21:26PM +0100, Stefano Brivio wrote: > ...they are simple enable/disable options. >=20 > Fixes: 89678c515755 ("conf, udp: Introduce basic DNS forwarding") > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > passt.1 | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/passt.1 b/passt.1 > index e97ef73..9c492f5 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -237,28 +237,28 @@ list altogether (if you need to search a domain cal= led "none" you can use > \fB--search none.\fR). > =20 > .TP > -.BR \-\-no-dhcp-dns " " \fIaddr > +.BR \-\-no-dhcp-dns > In \fIpasst\fR mode, do not assign IPv4 addresses via DHCP (option 23) o= r IPv6 > addresses via NDP Router Advertisement (option type 25) and DHCPv6 (opti= on 23) > as DNS resolvers. > By default, all the configured addresses are passed. > =20 > .TP > -.BR \-\-dhcp-dns " " \fIaddr > +.BR \-\-dhcp-dns > In \fIpasta\fR mode, assign IPv4 addresses via DHCP (option 23) or IPv6 > addresses via NDP Router Advertisement (option type 25) and DHCPv6 (opti= on 23) > as DNS resolvers. > By default, configured addresses, if any, are not passed. > =20 > .TP > -.BR \-\-no-dhcp-search " " \fIaddr > +.BR \-\-no-dhcp-search > In \fIpasst\fR mode, do not send the DNS domain search list addresses vi= a DHCP > (option 119), via NDP Router Advertisement (option type 31) and DHCPv6 (= option > 24). > By default, the DNS domain search list resulting from configuration is p= assed. > =20 > .TP > -.BR \-\-dhcp-search " " \fIaddr > +.BR \-\-dhcp-search > In \fIpasta\fR mode, send the DNS domain search list addresses via DHCP = (option > 119), via NDP Router Advertisement (option type 31) and DHCPv6 (option 2= 4). > By default, the DNS domain search list resulting from configuration is n= ot --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --g3W8XB1TZSq6whAq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmXyXScACgkQzQJF27ox 2GfBdw/+PpCpITM+bhYLa7gN9iwBDHvimkkk64D7QmQpWMMkGT7B/CWm4IWI5Hh0 VTtEC/0lx6k/jzY6/1S8E/FLGYmlOUTdKZCdSKTw0Wzf9CTTkWv5YPWQNdh9pFvX L5DIqpSHSZXztZ3Ekei3mjE9D9BGDrJESY0eh7VFKGTQ/BTPJTEH8O4bpVy8X0Bo nlK9TMdJWUbEpctH57/GULWZ837kDR+P7fd/uEZGDtrqzqyLBoqlWcUgXPGtRplr WRJRrmfZZC2FwTtjvtCVbI4IPl2i3Bt4hXkg2KlPMfaTDoWQ26sWE62svVyNkX+U +yXyztNv2tnEVGfKkszvXei2w3wdu8+X4BbUomXUTKTO4CsDKqJgcB01tNw8P9zA 9EvokuwoZaGSIJu8qZNPyaH/jz4OGAHQVb8hUt6rdWzK/Oyv8tMd3egEWFrjEsez 1BR6SfWa0SwWlppzWcj6t8Cwp9G+dE8DIsf6d+90S4gaeEf/GcKUDotlaiMXJEf6 jIvW0eVXC9KtriwPfqRPUlouNu6PrFbLAPbwvpKAx9tYHjf1y6ahVwYF4ZGmGA+X HxIi7uEuErnr0pMffL5AgRf7Ay6fDrPbWXb4kQZN3QN80RBoCVY+BNlu/tqFPBFN chdoCmdmo2+BGG1q1exH88VTQF03NuSYYMaG5DF2NjFP16NWbeA= =SswO -----END PGP SIGNATURE----- --g3W8XB1TZSq6whAq--