On Thu, Mar 14, 2024 at 05:54:10AM +0100, Stefano Brivio wrote: > On Thu, 14 Mar 2024 13:17:02 +1100 > David Gibson wrote: > > > On Tue, Mar 12, 2024 at 08:21:36AM +0100, Stefano Brivio wrote: > > > ...that is, call add_dns4() and add_dns6() instead of simply adding > > > those to the list of servers we advertise. > > > > > > Most importantly, this will set the 'dns_host' field for the matching > > > IP version, so that, as mentioned in the man page, servers passed via > > > --dns are used for DNS mapping as well, if used in combination with > > > --dns-forward. > > > > > > Reported-by: Paul Holzinger > > > Link: https://bugs.passt.top/show_bug.cgi?id=82 > > > Fixes: 89678c515755 ("conf, udp: Introduce basic DNS forwarding") > > > Signed-off-by: Stefano Brivio > > > > Reviewed-by: David Gibson > > > > This does subtly change semantics: addresses given to --dns are now > > host addresses, rather than guest addresses. I think the new meaning > > is less cryptic, though. > > Right, yes. But as we introduced the feature, the man page said, from > the beginning: > > -D, --dns addr > Use addr (IPv4 or IPv6) for DHCP, DHCPv6, NDP or DNS forwarding [...] > > so we have to change/fix semantics, I guess. Right, it's not really clear from the man page whether it's a host or guest address. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson