From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 56AF55A026F for ; Thu, 14 Mar 2024 06:08:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1710392911; bh=UZtTY/ySue3l0PcOwKOR0Faiu/fV+4/I84m8jRGSURo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eNyDOhgFiKnc3zkD5cREgNp9Fxg52s3DNKhUDxBtcVKzq+BegP4Vk2bg/ElS6lMI4 906aKQOQZk95HAwo2TR1ZrH/NF4vYWhYQoauhBODO6Z7R8w9g3qRCUjHznCo/u0HI6 CcqiKsWmIgAe7NG+HyFnYjhRTP163C9orgCffHebhzVwqhN5I0VM+mq/D14IGW5YFd anzw+xGXI61mSuM+DXt/zNvYJ1Oqs1Ge544aa2OGU1/I4Fwppm7az4wxTdxUFajAvq 9+9klsykpGalB0P3FrmGvMzZxEIQR/GLlODAIjCZNtIGFZaqsvDRNdZu33wFHeSg7V qvXMfvKhWILQQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4TwFlM5l4kz4wqM; Thu, 14 Mar 2024 16:08:31 +1100 (AEDT) Date: Thu, 14 Mar 2024 16:08:21 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] conf: Handle addresses passed via --dns just like the ones from resolv.conf Message-ID: References: <20240312072136.225197-1-sbrivio@redhat.com> <20240314055348.421e7622@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a7sdt3rP+rrMyPN6" Content-Disposition: inline In-Reply-To: <20240314055348.421e7622@elisabeth> Message-ID-Hash: 4XIYAGKNWTRBVWQI6KEBK2AO2NRVJN5G X-Message-ID-Hash: 4XIYAGKNWTRBVWQI6KEBK2AO2NRVJN5G X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --a7sdt3rP+rrMyPN6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 14, 2024 at 05:54:10AM +0100, Stefano Brivio wrote: > On Thu, 14 Mar 2024 13:17:02 +1100 > David Gibson wrote: >=20 > > On Tue, Mar 12, 2024 at 08:21:36AM +0100, Stefano Brivio wrote: > > > ...that is, call add_dns4() and add_dns6() instead of simply adding > > > those to the list of servers we advertise. > > >=20 > > > Most importantly, this will set the 'dns_host' field for the matching > > > IP version, so that, as mentioned in the man page, servers passed via > > > --dns are used for DNS mapping as well, if used in combination with > > > --dns-forward. > > >=20 > > > Reported-by: Paul Holzinger > > > Link: https://bugs.passt.top/show_bug.cgi?id=3D82 > > > Fixes: 89678c515755 ("conf, udp: Introduce basic DNS forwarding") > > > Signed-off-by: Stefano Brivio =20 > >=20 > > Reviewed-by: David Gibson > >=20 > > This does subtly change semantics: addresses given to --dns are now > > host addresses, rather than guest addresses. I think the new meaning > > is less cryptic, though. >=20 > Right, yes. But as we introduced the feature, the man page said, from > the beginning: >=20 > -D, --dns addr > Use addr (IPv4 or IPv6) for DHCP, DHCPv6, NDP or DNS forwarding [..= =2E] >=20 > so we have to change/fix semantics, I guess. Right, it's not really clear from the man page whether it's a host or guest address. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --a7sdt3rP+rrMyPN6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmXyhjQACgkQzQJF27ox 2GffRg/+KkOv92Q0cx6yROCdu8CunNlkp9ZeBhiCgClHExKktL+69wXWYPEMm4We QxhclYXn1Ac49xERiW+6QhqFAz7sSHdC25dJe3PMg0vCGyGPLv93NKxIclVJjCv5 7j0RH1N8X/R2G+InbesF5bWLp5O6szT4i4J+iy8c8uPap2rXQCi3fk9YHVs8h/Ss EKGZVqk68KZCIvDikpNgMvpF2Aq9J8OjzIBSf9jOD5LWqI4KQNA1RoV//FFegqS2 JdQ0nzOisjCFst8gEBv/yBMeuI3UWNdhrWfd5BaCXfcVpMEEdTZPddhcTRwyemaY T++WJB1VHNfqAvoZ5eDJnkOPerw9/PCta1hw0RvddJ8sruDx+EwpDzSLr4BuDqn8 o+DGkFfvY6rdyu+jB9HP87NzwHn/amTfREId1mGVz9swQVGbIzjBOzHtZFQFw/eg KAVZuWdF0dDwW+AgV6HYQhpxbhhREbNpL19o3417wohk3IK5uqmXIn0ykhmG/mUH KibmMGzWzvRku7nSNliUNw17YENdLbpF6/eR2OnQZWYgiH2cdKaGyvkeWYhjWV3U 5J6TEj44gX/036ljwWOmAkbuMxHn9tdO9Gc6gxWPyz+yDkO9Oee8vVs95Dx1gTIF OTyOWYtMw2jXDjh7LVc7nGDNdn0ho1VnwF4fwf74lhAy33oHtuU= =ZRk8 -----END PGP SIGNATURE----- --a7sdt3rP+rrMyPN6--